Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1321753002: Revert of Preliminary change for new rtc rendering algorithm (Closed)

Created:
5 years, 3 months ago by phoglund_chromium
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, sunnyps, mcasas, DaleCurtis, miu, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Preliminary change for new rtc rendering algorithm (patchset #4 id:60001 of https://codereview.chromium.org/1306203002/ ) Reason for revert: Speculative revert: WebRTC video seems to have gotten choppier. Reverting to see if this patch is the culprit. See http://crbug.com/525264. Original issue's description: > Preliminary change for new rtc rendering algorithm: > > 1. Add trace flags for smoothness testing > > 2. Propagate render_time calculated in Jitter Buffer to media::VideoFrame for new rendering algorithm to use. > > 3. Move invalidation trigger to compositor thread. > > > This is a recommit of CL 1265433003, the original CL was reverted because it breaks Blink Layout tests. > > BUG=514873 > > TBR=sunnyps@chromium.org,mcasas@chromium.org,dalecurtis@chromium.org,miu@chromium.org,piman@chromium.org > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:win_blink_rel > > Committed: https://crrev.com/c1e6f1defc961774afa95af08c5fb457816e8492 > Cr-Commit-Position: refs/heads/master@{#345200} TBR=pfeldman@chromium.org,sievers@chromium.org,mcasas@chromium.org,qiangchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514873 Committed: https://crrev.com/24cd5f248340f751cb9aae593cfecd555fa78fe8 Cr-Commit-Position: refs/heads/master@{#346095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -309 lines) Patch
M content/renderer/media/video_capture_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 4 chunks +32 lines, -73 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 15 chunks +104 lines, -193 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 5 chunks +1 line, -21 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/video_frame_metadata.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Preliminary change for new rtc rendering algorithm
5 years, 3 months ago (2015-08-28 07:11:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321753002/1
5 years, 3 months ago (2015-08-28 07:11:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 07:12:07 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 07:12:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24cd5f248340f751cb9aae593cfecd555fa78fe8
Cr-Commit-Position: refs/heads/master@{#346095}

Powered by Google App Engine
This is Rietveld 408576698