Use the site engagement eviction policy for temporary storage eviction.

Use the site engagement eviction policy for temporary storage eviction.

This CL hooks up the SiteEngagementEvictionPolicy to the temporary storage
eviction system. This involves adding a QuotaTask to QuotaManager which
fetches information necessary for eviction calculation and then passes it
to the eviction policy which is owned by the SiteEngagementService.

This features is behind the --enable-site-engagement-storage-eviction flag.

BUG=464234

[calamity, 2015-09-01 04:55:06]

Patchset #1 (id:1) has been deleted

[calamity, 2015-09-01 04:55:27]

calamity@chromium.org changed reviewers:
+ raymes@chromium.org

[calamity, 2015-09-01 04:55:27]

+raymes for initial review

[raymes, 2015-09-01 06:52:52]

Looks good overall - I haven't reviewed the storage/ stuff because it's so
foreign to me. I'll leave that to the storage guys :)

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.cc (right):

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.cc:168: new
SiteEngagementEvictionPolicy(profile)) {}
Should SiteEngagementService depend on SiteEngagementEvictionPolicy (which
already depends on it)?

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:123:
SiteEngagementEvictionPolicy* GetSiteEngagementEvictionPolicy() {
site_engagement_eviction_policy()

[calamity, 2015-09-04 05:44:21]

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.cc (right):

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.cc:168: new
SiteEngagementEvictionPolicy(profile)) {}
On 2015/09/01 06:52:52, raymes wrote:
> Should SiteEngagementService depend on SiteEngagementEvictionPolicy (which
> already depends on it)?

Forgot to put in the enable condition.

What do you mean by this? The eviction policy needs to live somewhere and this
seemed like a decent place. We could also add a new keyed service for it I
guess?

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1321733004/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_service.h:123:
SiteEngagementEvictionPolicy* GetSiteEngagementEvictionPolicy() {
On 2015/09/01 06:52:52, raymes wrote:
> site_engagement_eviction_policy()

Done.