Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1321723009: Protocol handlers should be able to register a service worker.

Created:
5 years, 3 months ago by pals
Modified:
4 years, 11 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Protocol handlers should be able to register a service worker. BUG=522370

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : test2 #

Patch Set 4 : test2 #

Patch Set 5 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pals
On 2015/09/16 09:04:25, pals wrote: > mailto:sanjoy.pal@samsung.com changed reviewers: > + mailto:nhiroki@chromium.org I was trying ...
5 years, 3 months ago (2015-09-16 09:07:01 UTC) #2
nhiroki
I'm sorry for my delayed reply (I was in a long vacation and stuck at ...
5 years, 2 months ago (2015-10-05 09:02:08 UTC) #4
pals
5 years, 2 months ago (2015-10-07 06:09:25 UTC) #5
On 2015/10/05 09:02:08, nhiroki wrote:
> I'm sorry for my delayed reply (I was in a long vacation and stuck at other P0
> issue...)
> 
> > Protocol handlers should be able to register a service worker.
> 
> Is this what the issue 522370 means? The issue seems to mean that a request
> initiated by the protocol handler should not bypass the fetch event, but
> actually it does.

As the handler URL is not able to register SW, fetch event is bypassed. I may be
wrong, I shall remove myself from owner of this issue and make it available as I
am working few other issues.

Powered by Google App Engine
This is Rietveld 408576698