Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321723004: Make classes and structures in core/xml, core/input, core/imagebitmap and core/Init fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/xml, core/input, core/imagebitmap and core/Init fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201480

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M Source/core/Init.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/imagebitmap/ImageBitmapFactories.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/input/EventHandler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/xml/DocumentXPathEvaluator.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/DocumentXSLT.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/XPathParser.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/parser/XMLParserInput.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-08-31 11:01:23 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-08-31 11:08:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321723004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321723004/20001
5 years, 3 months ago (2015-08-31 11:16:51 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 11:36:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201480

Powered by Google App Engine
This is Rietveld 408576698