chrome/browser/ui/browser_tab_strip_model_delegate.cc - Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tab_strip_model_delegate.cc

Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_tab_strip_model_delegate.cc

diff --git a/chrome/browser/ui/browser_tab_strip_model_delegate.cc b/chrome/browser/ui/browser_tab_strip_model_delegate.cc

index dcf149208102862638c99a82bbe95b91e3b6ee8f..504c6399d24ad68b0919d574fd67fa825a891286 100644

--- a/chrome/browser/ui/browser_tab_strip_model_delegate.cc

+++ b/chrome/browser/ui/browser_tab_strip_model_delegate.cc

@@ -21,6 +21,7 @@

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/browser/ui/unload_controller.h"

#include "chrome/common/chrome_switches.h"

+#include "components/sessions/content/content_live_tab.h"

#include "content/public/browser/site_instance.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_delegate.h"

@@ -118,7 +119,7 @@ void BrowserTabStripModelDelegate::CreateHistoricalTab(

// We only create historical tab entries for tabbed browser windows.

if (service && browser_->CanSupportWindowFeature(Browser::FEATURE_TABSTRIP)) {

service->CreateHistoricalTab(

- contents,

+ sessions::ContentLiveTab::FromWebContents(contents),

browser_->tab_strip_model()->GetIndexOfWebContents(contents));

}

« no previous file with comments | « chrome/browser/ui/browser_tab_restore_service_delegate.cc ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »