Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2242)

Unified Diff: chrome/browser/sessions/tab_restore_service_delegate.h

Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/tab_restore_service.h ('k') | chrome/browser/sessions/tab_restore_service_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/tab_restore_service_delegate.h
diff --git a/chrome/browser/sessions/tab_restore_service_delegate.h b/chrome/browser/sessions/tab_restore_service_delegate.h
index f9bd07e33ba8ecb2aa11892d00d76668004b69f9..af912f1c3f621f6f4533277888224b2feb6c4995 100644
--- a/chrome/browser/sessions/tab_restore_service_delegate.h
+++ b/chrome/browser/sessions/tab_restore_service_delegate.h
@@ -10,9 +10,8 @@
#include "components/sessions/session_id.h"
-namespace content {
-class NavigationController;
-class WebContents;
+namespace sessions {
+class LiveTab;
}
namespace sessions {
@@ -40,15 +39,14 @@ class TabRestoreServiceDelegate {
// see Browser::app_name()
virtual std::string GetAppName() const = 0;
- // see Browser methods with the same names
- virtual content::WebContents* GetWebContentsAt(int index) const = 0;
- virtual content::WebContents* GetActiveWebContents() const = 0;
+ virtual sessions::LiveTab* GetLiveTabAt(int index) const = 0;
+ virtual sessions::LiveTab* GetActiveLiveTab() const = 0;
virtual bool IsTabPinned(int index) const = 0;
// Note: |tab_client_data| may be null (e.g., if |from_last_session| is true,
// as the tab client data is not persisted, or if the embedder did not supply
// client data for the tab in question).
- virtual content::WebContents* AddRestoredTab(
+ virtual sessions::LiveTab* AddRestoredTab(
const std::vector<sessions::SerializedNavigationEntry>& navigations,
int tab_index,
int selected_navigation,
@@ -61,7 +59,7 @@ class TabRestoreServiceDelegate {
// Note: |tab_client_data| may be null (e.g., if |from_last_session| is true,
// as the tab client data is not persisted, or if the embedder did not supply
- virtual content::WebContents* ReplaceRestoredTab(
+ virtual sessions::LiveTab* ReplaceRestoredTab(
const std::vector<sessions::SerializedNavigationEntry>& navigations,
int selected_navigation,
bool from_last_session,
« no previous file with comments | « chrome/browser/sessions/tab_restore_service.h ('k') | chrome/browser/sessions/tab_restore_service_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698