chrome/browser/sessions/in_memory_tab_restore_service.h - Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/in_memory_tab_restore_service.h

Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/chrome_tab_restore_service_client.cc ('k') | chrome/browser/sessions/in_memory_tab_restore_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/in_memory_tab_restore_service.h

diff --git a/chrome/browser/sessions/in_memory_tab_restore_service.h b/chrome/browser/sessions/in_memory_tab_restore_service.h

index 59cbc7287c996486355b1a454557d08820149475..4aca30d8f42e7334545329258b09bd61b1e26188 100644

--- a/chrome/browser/sessions/in_memory_tab_restore_service.h

+++ b/chrome/browser/sessions/in_memory_tab_restore_service.h

@@ -34,16 +34,16 @@ class InMemoryTabRestoreService : public TabRestoreService {

// TabRestoreService:

void AddObserver(TabRestoreServiceObserver* observer) override;

void RemoveObserver(TabRestoreServiceObserver* observer) override;

- void CreateHistoricalTab(content::WebContents* contents, int index) override;

+ void CreateHistoricalTab(sessions::LiveTab* live_tab, int index) override;

void BrowserClosing(TabRestoreServiceDelegate* delegate) override;

void BrowserClosed(TabRestoreServiceDelegate* delegate) override;

void ClearEntries() override;

const Entries& entries() const override;

- std::vector<content::WebContents*> RestoreMostRecentEntry(

+ std::vector<sessions::LiveTab*> RestoreMostRecentEntry(

TabRestoreServiceDelegate* delegate,

int host_desktop_type) override;

Tab* RemoveTabEntryById(SessionID::id_type id) override;

- std::vector<content::WebContents*> RestoreEntryById(

+ std::vector<sessions::LiveTab*> RestoreEntryById(

TabRestoreServiceDelegate* delegate,

SessionID::id_type id,

int host_desktop_type,