chrome/browser/sessions/chrome_tab_restore_service_client.h - Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/chrome_tab_restore_service_client.h

Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_api.cc ('k') | chrome/browser/sessions/chrome_tab_restore_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/chrome_tab_restore_service_client.h

diff --git a/chrome/browser/sessions/chrome_tab_restore_service_client.h b/chrome/browser/sessions/chrome_tab_restore_service_client.h

index 4680d2fff39c0e1003f1b444c4333f629e0f35fd..4bd2c421a9ed89afb625837ba275c4750dd9250a 100644

--- a/chrome/browser/sessions/chrome_tab_restore_service_client.h

+++ b/chrome/browser/sessions/chrome_tab_restore_service_client.h

@@ -22,16 +22,15 @@ class ChromeTabRestoreServiceClient : public sessions::TabRestoreServiceClient {

TabRestoreServiceDelegate* CreateTabRestoreServiceDelegate(

int host_desktop_type,

const std::string& app_name) override;

- TabRestoreServiceDelegate* FindTabRestoreServiceDelegateForWebContents(

- const content::WebContents* contents) override;

+ TabRestoreServiceDelegate* FindTabRestoreServiceDelegateForTab(

+ const sessions::LiveTab* tab) override;

TabRestoreServiceDelegate* FindTabRestoreServiceDelegateWithID(

SessionID::id_type desired_id,

int host_desktop_type) override;

bool ShouldTrackURLForRestore(const GURL& url) override;

- std::string GetExtensionAppIDForWebContents(

- content::WebContents* web_contents) override;

- scoped_ptr<sessions::TabClientData> GetTabClientDataForWebContents(

- content::WebContents* web_contents) override;

+ std::string GetExtensionAppIDForTab(sessions::LiveTab* tab) override;

+ scoped_ptr<sessions::TabClientData> GetTabClientDataForTab(

+ sessions::LiveTab* tab) override;

base::SequencedWorkerPool* GetBlockingPool() override;

base::FilePath GetPathToSaveTo() override;

GURL GetNewTabURL() override;