components/sessions.gypi - Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sessions.gypi

Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/panel_host.cc ('K') | « chrome/browser/ui/webui/signin/inline_login_ui.cc ('k') | components/sessions/BUILD.gn » ('j') | components/sessions/content/content_open_tab.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sessions.gypi

diff --git a/components/sessions.gypi b/components/sessions.gypi

index 0428a46ad9c501e72c8dcfcd28fb4143b70c0ee8..549df76082d3c28755f832860628ddd4d66feeaf 100644

--- a/components/sessions.gypi

+++ b/components/sessions.gypi

@@ -13,6 +13,7 @@

'sessions/base_session_service_commands.cc',

'sessions/base_session_service_commands.h',

'sessions/base_session_service_delegate.h',

+ 'sessions/core/open_tab.h',

'sessions/core/serialized_navigation_driver.h',

'sessions/core/session_constants.cc',

'sessions/core/session_constants.h',

@@ -68,7 +69,7 @@

{

# GN version: //components/sessions

'target_name': 'sessions_content',

- 'type': '<(component)',

+ 'type': 'static_library',

blundell 2015/09/16 16:20:36 You can ignore this; it's a temporary workaround f

'dependencies': [

'../base/base.gyp:base',

'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',

@@ -90,6 +91,8 @@

# Note: sources list duplicated in GN build.

'<@(sessions_core_sources)',

+ 'sessions/content/content_open_tab.cc',

+ 'sessions/content/content_open_tab.h',

'sessions/content/content_serialized_navigation_builder.cc',

'sessions/content/content_serialized_navigation_builder.h',

'sessions/content/content_serialized_navigation_driver.cc',