chrome/browser/android/tab_android.cc - Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 1321713005: Abstract WebContents/NavigationController from core TabRestore code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index 8b28116b8bf6d31305b2e82e1e5c8ff50ea68eef..46619ed20cc8db6d805f380be04bd94e4d1e9676 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -63,6 +63,7 @@

#include "components/offline_pages/offline_page_feature.h"

#include "components/offline_pages/offline_page_item.h"

#include "components/offline_pages/offline_page_model.h"

+#include "components/sessions/content/content_open_tab.h"

#include "components/url_formatter/url_fixer.h"

#include "content/public/browser/android/compositor.h"

#include "content/public/browser/android/content_view_core.h"

@@ -736,7 +737,8 @@ void TabAndroid::CreateHistoricalTabFromContents(WebContents* web_contents) {

}

// TODO(jcivelli): is the index important?

- service->CreateHistoricalTab(web_contents, -1);

+ service->CreateHistoricalTab(

+ sessions::ContentOpenTab::FromWebContents(web_contents), -1);

}

void TabAndroid::CreateHistoricalTab(JNIEnv* env, jobject obj) {

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/webui_login_view.cc » ('j') | chrome/browser/ui/panels/panel_host.cc » ('J')