Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1321713004: Flag for Material Design policy construction page (Closed)

Created:
5 years, 3 months ago by fhorschig
Modified:
5 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flag for Material Design policy construction page Setting the flag loads an empty page at chrome://md-policy. This is the scaffold for further development on the new Material Design policy page without influencing the old one. BUG=134849 Committed: https://crrev.com/c9018a4fe33078586afd9a0d3568f6fb15d44335 Cr-Commit-Position: refs/heads/master@{#352800}

Patch Set 1 : Added flag and made policy ui react on it. #

Patch Set 2 : Added flag to historgram. #

Total comments: 10

Patch Set 3 : Added test for non-flag use. #

Total comments: 12

Patch Set 4 : Simplified test instantiation. #

Total comments: 4

Patch Set 5 : Moved policy page to independent page. #

Total comments: 5

Patch Set 6 : Added ID to iOS Whitelist. #

Patch Set 7 : Readded destructor. #

Total comments: 6

Patch Set 8 : Addressing nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -6 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/md_policy/md_policy.html View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.h View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 2 3 4 5 6 7 3 chunks +27 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (12 generated)
fhorschig
This is only the flag for development. The actual implementation of WebUI and material design ...
5 years, 3 months ago (2015-09-22 11:46:41 UTC) #4
bartfab (slow)
https://codereview.chromium.org/1321713004/diff/60001/chrome/browser/ui/webui/policy_ui_browsertest.cc File chrome/browser/ui/webui/policy_ui_browsertest.cc (right): https://codereview.chromium.org/1321713004/diff/60001/chrome/browser/ui/webui/policy_ui_browsertest.cc#newcode98 chrome/browser/ui/webui/policy_ui_browsertest.cc:98: void SetUpCommandLine(base::CommandLine* command_line) override; Nit: // InProcessBrowserTest: https://codereview.chromium.org/1321713004/diff/60001/chrome/browser/ui/webui/policy_ui_browsertest.cc#newcode140 chrome/browser/ui/webui/policy_ui_browsertest.cc:140: ...
5 years, 3 months ago (2015-09-23 12:57:49 UTC) #5
fhorschig
Thanks for pointing me to parameterized tests! https://codereview.chromium.org/1321713004/diff/60001/chrome/browser/ui/webui/policy_ui_browsertest.cc File chrome/browser/ui/webui/policy_ui_browsertest.cc (right): https://codereview.chromium.org/1321713004/diff/60001/chrome/browser/ui/webui/policy_ui_browsertest.cc#newcode98 chrome/browser/ui/webui/policy_ui_browsertest.cc:98: void SetUpCommandLine(base::CommandLine* ...
5 years, 3 months ago (2015-09-23 16:18:26 UTC) #6
bartfab (slow)
https://codereview.chromium.org/1321713004/diff/80001/chrome/browser/ui/webui/policy_ui_browsertest.cc File chrome/browser/ui/webui/policy_ui_browsertest.cc (right): https://codereview.chromium.org/1321713004/diff/80001/chrome/browser/ui/webui/policy_ui_browsertest.cc#newcode43 chrome/browser/ui/webui/policy_ui_browsertest.cc:43: struct UrlForFlag { Nit: This is nifty but a ...
5 years, 3 months ago (2015-09-23 17:17:13 UTC) #7
fhorschig
https://codereview.chromium.org/1321713004/diff/80001/chrome/browser/ui/webui/policy_ui_browsertest.cc File chrome/browser/ui/webui/policy_ui_browsertest.cc (right): https://codereview.chromium.org/1321713004/diff/80001/chrome/browser/ui/webui/policy_ui_browsertest.cc#newcode43 chrome/browser/ui/webui/policy_ui_browsertest.cc:43: struct UrlForFlag { On 2015/09/23 17:17:13, bartfab wrote: > ...
5 years, 2 months ago (2015-09-25 08:27:15 UTC) #8
fhorschig
+tnagel
5 years, 2 months ago (2015-09-25 10:00:26 UTC) #10
Thiemo Nagel
On 2015/09/25 10:00:26, fhorschig wrote: > +tnagel Please be clearer in the CL description about ...
5 years, 2 months ago (2015-09-25 11:33:43 UTC) #11
fhorschig
On 2015/09/25 11:33:43, Thiemo Nagel wrote: > On 2015/09/25 10:00:26, fhorschig wrote: > > +tnagel ...
5 years, 2 months ago (2015-09-25 11:54:37 UTC) #12
Thiemo Nagel
On 2015/09/25 11:54:37, fhorschig wrote: > On 2015/09/25 11:33:43, Thiemo Nagel wrote: > > On ...
5 years, 2 months ago (2015-09-25 11:59:47 UTC) #13
Thiemo Nagel
https://codereview.chromium.org/1321713004/diff/100001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/1321713004/diff/100001/chrome/browser/about_flags.cc#newcode1655 chrome/browser/about_flags.cc:1655: #if !defined(OS_ANDROID) && !defined(OS_IOS) Why don't you support Android ...
5 years, 2 months ago (2015-09-25 12:22:09 UTC) #14
fhorschig
All new, all different. Updated title, description and concept. Due to rebase, Some three minor ...
5 years, 2 months ago (2015-09-25 15:15:53 UTC) #16
Thiemo Nagel
https://codereview.chromium.org/1321713004/diff/140001/chrome/browser/ui/webui/policy_ui.cc File chrome/browser/ui/webui/policy_ui.cc (right): https://codereview.chromium.org/1321713004/diff/140001/chrome/browser/ui/webui/policy_ui.cc#newcode892 chrome/browser/ui/webui/policy_ui.cc:892: PolicyMaterialDesignUI::~PolicyMaterialDesignUI() { What's the purpose of this? https://codereview.chromium.org/1321713004/diff/140001/chrome/browser/ui/webui/policy_ui.h File ...
5 years, 2 months ago (2015-09-25 15:49:30 UTC) #17
fhorschig
https://codereview.chromium.org/1321713004/diff/140001/chrome/browser/ui/webui/policy_ui.cc File chrome/browser/ui/webui/policy_ui.cc (right): https://codereview.chromium.org/1321713004/diff/140001/chrome/browser/ui/webui/policy_ui.cc#newcode892 chrome/browser/ui/webui/policy_ui.cc:892: PolicyMaterialDesignUI::~PolicyMaterialDesignUI() { On 2015/09/25 15:49:30, Thiemo Nagel wrote: > ...
5 years, 2 months ago (2015-09-28 09:38:58 UTC) #20
Thiemo Nagel
https://codereview.chromium.org/1321713004/diff/140001/chrome/browser/ui/webui/policy_ui.cc File chrome/browser/ui/webui/policy_ui.cc (right): https://codereview.chromium.org/1321713004/diff/140001/chrome/browser/ui/webui/policy_ui.cc#newcode892 chrome/browser/ui/webui/policy_ui.cc:892: PolicyMaterialDesignUI::~PolicyMaterialDesignUI() { > In case you are asking about ...
5 years, 2 months ago (2015-09-28 12:02:20 UTC) #21
Thiemo Nagel
> My bad. "Empty" destructors are used to prevent destructor inlining: > https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-inlining-constructors-and-destructors. LGTM % ...
5 years, 2 months ago (2015-09-28 13:25:53 UTC) #22
fhorschig
Hi Dan, would you please have a look at the chrome/browser/* files?
5 years, 2 months ago (2015-10-06 09:10:57 UTC) #25
fhorschig
Hi Jesse, would you please have a quick look on tools/metrics/histograms/histograms.xml?
5 years, 2 months ago (2015-10-06 09:15:45 UTC) #27
jwd
lgtm
5 years, 2 months ago (2015-10-06 14:36:27 UTC) #28
Dan Beam
lgtm w/nits (also, make sure to put the Subject in the review description: only the ...
5 years, 2 months ago (2015-10-06 16:00:15 UTC) #29
fhorschig
Thanks for the advice and editing the description! https://codereview.chromium.org/1321713004/diff/240001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://codereview.chromium.org/1321713004/diff/240001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode548 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:548: switches::MdPolicyPageEnabled()) ...
5 years, 2 months ago (2015-10-06 16:57:13 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321713004/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321713004/260001
5 years, 2 months ago (2015-10-07 08:35:25 UTC) #33
commit-bot: I haz the power
Committed patchset #8 (id:260001)
5 years, 2 months ago (2015-10-07 08:42:01 UTC) #34
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 08:43:13 UTC) #35
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/c9018a4fe33078586afd9a0d3568f6fb15d44335
Cr-Commit-Position: refs/heads/master@{#352800}

Powered by Google App Engine
This is Rietveld 408576698