Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1321683009: Remove unused 'Credential::create' methods. (Closed)

Created:
5 years, 3 months ago by Mike West
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused 'Credential::create' methods. These methods are unused, and confusing. Let's remove them. BUG=494880 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M Source/modules/credentialmanager/Credential.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/credentialmanager/Credential.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mike West
Tiny CL to get you back into things. :) -mike
5 years, 3 months ago (2015-09-07 10:59:18 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-07 14:24:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321683009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321683009/1
5 years, 3 months ago (2015-09-08 07:04:37 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 07:08:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201900

Powered by Google App Engine
This is Rietveld 408576698