[Interpreter] Add support for loading literals from the constant pool.

src/interpreter/bytecode-array-builder.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_BYTECODE_ARRAY_BUILDER_H_
 #define V8_INTERPRETER_BYTECODE_ARRAY_BUILDER_H_
 
 #include <vector>
 
 #include "src/ast.h"
 #include "src/frames.h"
+#include "src/heap/identity-map.h"
 #include "src/interpreter/bytecodes.h"
+#include "src/zone.h"
 
 namespace v8 {
 namespace internal {
 
 class Isolate;
 
 namespace interpreter {
 
 class Register;
 
 class BytecodeArrayBuilder {
  public:
-  explicit BytecodeArrayBuilder(Isolate* isolate);
+  explicit BytecodeArrayBuilder(Isolate* isolate, Zone* zone);

[Michael Starzinger, 2015/08/28 12:21:04]

nit: No longer needs to be marked as explicit.

[rmcilroy, 2015/08/28 14:42:05]

Done.

   Handle<BytecodeArray> ToBytecodeArray();
 
   // Set number of parameters expected by function.
   void set_parameter_count(int number_of_params);
   int parameter_count() const;
 
   // Set number of locals required for bytecode array.
   void set_locals_count(int number_of_locals);
   int locals_count() const;
 
   Register Parameter(int parameter_index);
 
   // Constant loads to accumulator.
   BytecodeArrayBuilder& LoadLiteral(v8::internal::Smi* value);
+  BytecodeArrayBuilder& LoadLiteral(Handle<Object> object);
   BytecodeArrayBuilder& LoadUndefined();
   BytecodeArrayBuilder& LoadNull();
   BytecodeArrayBuilder& LoadTheHole();
   BytecodeArrayBuilder& LoadTrue();
   BytecodeArrayBuilder& LoadFalse();
 
   // Register-accumulator transfers.
   BytecodeArrayBuilder& LoadAccumulatorWithRegister(Register reg);
   BytecodeArrayBuilder& StoreAccumulatorInRegister(Register reg);
 
@@ skipping 10 matching lines @@
   static Bytecode BytecodeForBinaryOperation(Token::Value op);
 
   void Output(Bytecode bytecode, uint8_t r0, uint8_t r1, uint8_t r2);
   void Output(Bytecode bytecode, uint8_t r0, uint8_t r1);
   void Output(Bytecode bytecode, uint8_t r0);
   void Output(Bytecode bytecode);
 
   bool OperandIsValid(Bytecode bytecode, int operand_index,
                       uint8_t operand_value) const;
 
+  size_t GetConstantPoolEntry(Handle<Object> object);
+
   int BorrowTemporaryRegister();
   void ReturnTemporaryRegister(int reg_index);
 
   Isolate* isolate_;
   std::vector<uint8_t> bytecodes_;

[Michael Starzinger, 2015/08/28 12:21:04]

Same comment from below applies here.

[rmcilroy, 2015/08/28 14:42:05]

Done.

   bool bytecode_generated_;
 
+  IdentityMap<size_t> constants_map_;
+  std::vector<Handle<Object>> constants_;

[Michael Starzinger, 2015/08/28 12:21:04]

Could we use a ZoneVector here, that would provide us with accounting for the
(zone) memory footprint of the interpreter later (i.e. similar to --turbo-stats)

[rmcilroy, 2015/08/28 14:42:05]

Done.

+
   int parameter_count_;
   int local_register_count_;
   int temporary_register_count_;
   int temporary_register_next_;
 
   friend class TemporaryRegisterScope;
   DISALLOW_IMPLICIT_CONSTRUCTORS(BytecodeArrayBuilder);
 };
 
 // An interpreter register which is located in the function's register file
@@ skipping 40 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(TemporaryRegisterScope);
 };
 
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_BYTECODE_ARRAY_BUILDER_H_