Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 132163006: Rename media/base/bind_to_loop.h to media/base/bind_to_current_loop.h. (Closed)

Created:
6 years, 11 months ago by scherkus (not reviewing)
Modified:
6 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Rename media/base/bind_to_loop.h to media/base/bind_to_current_loop.h. BUG=167240 R=xhwang@chromium.org TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244099

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -490 lines) Patch
M chrome/renderer/media/cast_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_device_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_bridge_tv.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_factory_tv.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/texttrack_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webaudiosourceprovider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_device_listener_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_decoder_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/base/bind_to_current_loop.h View 4 chunks +4 lines, -6 lines 0 comments Download
A + media/base/bind_to_current_loop.h.pump View 3 chunks +3 lines, -5 lines 0 comments Download
A + media/base/bind_to_current_loop_unittest.cc View 11 chunks +12 lines, -12 lines 2 comments Download
D media/base/bind_to_loop.h View 1 chunk +0 lines, -168 lines 0 comments Download
D media/base/bind_to_loop.h.pump View 1 chunk +0 lines, -92 lines 0 comments Download
D media/base/bind_to_loop_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M media/base/callback_holder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/text_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_decoder_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decrypting_demuxer_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/fake_demuxer_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/fake_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/opus_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/video_decoder_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/video_frame_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
xhwang: you get this one :)
6 years, 11 months ago (2014-01-09 23:56:37 UTC) #1
xhwang
lgtm % one question https://codereview.chromium.org/132163006/diff/1/media/base/bind_to_current_loop_unittest.cc File media/base/bind_to_current_loop_unittest.cc (right): https://codereview.chromium.org/132163006/diff/1/media/base/bind_to_current_loop_unittest.cc#newcode49 media/base/bind_to_current_loop_unittest.cc:49: &base::WaitableEvent::Signal, base::Unretained(&waiter))); nit: How do ...
6 years, 11 months ago (2014-01-10 00:30:28 UTC) #2
scherkus (not reviewing)
https://codereview.chromium.org/132163006/diff/1/media/base/bind_to_current_loop_unittest.cc File media/base/bind_to_current_loop_unittest.cc (right): https://codereview.chromium.org/132163006/diff/1/media/base/bind_to_current_loop_unittest.cc#newcode49 media/base/bind_to_current_loop_unittest.cc:49: &base::WaitableEvent::Signal, base::Unretained(&waiter))); On 2014/01/10 00:30:29, xhwang wrote: > nit: ...
6 years, 11 months ago (2014-01-10 01:09:18 UTC) #3
xhwang
On 2014/01/10 01:09:18, scherkus wrote: > https://codereview.chromium.org/132163006/diff/1/media/base/bind_to_current_loop_unittest.cc > File media/base/bind_to_current_loop_unittest.cc (right): > > https://codereview.chromium.org/132163006/diff/1/media/base/bind_to_current_loop_unittest.cc#newcode49 > ...
6 years, 11 months ago (2014-01-10 01:13:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/132163006/1
6 years, 11 months ago (2014-01-10 01:24:39 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244584
6 years, 11 months ago (2014-01-10 04:59:26 UTC) #6
scherkus (not reviewing)
6 years, 11 months ago (2014-01-10 05:15:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r244099.

Powered by Google App Engine
This is Rietveld 408576698