Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 132163002: First set of changes to remove ENABLE_TOUCH_ICON_LOADING compile time flag. (Closed)

Created:
6 years, 11 months ago by maheshkk
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

First set of changes to remove ENABLE_TOUCH_ICON_LOADING compile time flag. Add TouchIconLoading runtime and the equivalent WebRuntimeFeature API. BUG=332863 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164808

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove stable from the flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
maheshkk
Please review.
6 years, 11 months ago (2014-01-09 16:59:27 UTC) #1
maheshkk
Chrome CL is here https://codereview.chromium.org/132173002 Once this patch lands I will publish for review.
6 years, 11 months ago (2014-01-09 17:24:45 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/132163002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/132163002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode125 Source/platform/RuntimeEnabledFeatures.in:125: TouchIconLoading status=stable I'd leave off the status. It's ...
6 years, 11 months ago (2014-01-09 18:21:09 UTC) #3
maheshkk
On 2014/01/09 18:21:09, abarth wrote: > lgtm > > https://codereview.chromium.org/132163002/diff/1/Source/platform/RuntimeEnabledFeatures.in > File Source/platform/RuntimeEnabledFeatures.in (right): > ...
6 years, 11 months ago (2014-01-09 20:35:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/132163002/70001
6 years, 11 months ago (2014-01-09 20:36:23 UTC) #5
commit-bot: I haz the power
Change committed as 164808
6 years, 11 months ago (2014-01-09 21:58:11 UTC) #6
maheshkk
6 years, 11 months ago (2014-01-09 22:13:24 UTC) #7
Message was sent while issue was closed.
Changes to remove compile time flag and use runtime flag instead.
 
Not sure if I can use same issue number to review next set of changes.

Powered by Google App Engine
This is Rietveld 408576698