[Sync] Use ModelTypeProcessor instead of ModelTypeProcessorImpl.

[Sync] Use ModelTypeProcessor instead of ModelTypeProcessorImpl.

This CL doesn't touch ModelTypeProcessorImpl in DataTypeController
because ModelTypeProcessor doesn't have the functionality for it.
Those uses will be removed in a separate refactor.

Also fixes a bunch of incorrect variable names.

BUG=517953
Committed: https://crrev.com/4824734c493af37e7602a27004bbc4a88aa04d6e
Cr-Commit-Position: refs/heads/master@{#347880}

[maxbogue, 2015-09-08 22:17:40]

maxbogue@chromium.org changed reviewers:
+ stanisc@chromium.org

[maxbogue, 2015-09-08 22:17:40]

Hey Stan, PTAL!

[stanisc, 2015-09-08 23:40:27]

In model_type_processor_impl.h should weak_ptr_factory_for_sync_ be changed from
base::WeakPtrFactory<ModelTypeProcessorImpl> to
base::WeakPtrFactory<ModelTypeProcessor>?

https://codereview.chromium.org/1321613003/diff/1/sync/engine/model_type_enti...
File sync/engine/model_type_entity_unittest.cc (right):

https://codereview.chromium.org/1321613003/diff/1/sync/engine/model_type_enti...
sync/engine/model_type_entity_unittest.cc:20: // ModelTypeProcessor that owns
the ModelTypeEntity.  We can't unit test it
In this case you shouldn't rename ModelTypeProcessorImpl to ModelTypeProcessor
because ModelTypeProcessor doesn't implement anything.
Or replace it with something like ModelTypeProcessor implementation.

[maxbogue, 2015-09-09 00:16:47]

I can't update the WeakPtrFactory yet because the DataTypeController needs to
get an Impl from it.

https://codereview.chromium.org/1321613003/diff/1/sync/engine/model_type_enti...
File sync/engine/model_type_entity_unittest.cc (right):

https://codereview.chromium.org/1321613003/diff/1/sync/engine/model_type_enti...
sync/engine/model_type_entity_unittest.cc:20: // ModelTypeProcessor that owns
the ModelTypeEntity.  We can't unit test it
On 2015/09/08 23:40:26, stanisc wrote:
> In this case you shouldn't rename ModelTypeProcessorImpl to ModelTypeProcessor
> because ModelTypeProcessor doesn't implement anything.
> Or replace it with something like ModelTypeProcessor implementation.

Reverted the changes to this file.

[stanisc, 2015-09-09 01:02:27]

lgtm

[maxbogue, 2015-09-09 01:06:33]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2015-09-09 01:07:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321613003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321613003/20001

[commit-bot: I haz the power, 2015-09-09 09:13:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-09 09:13:54]

Patchset 2 (id:??) landed as
https://crrev.com/4824734c493af37e7602a27004bbc4a88aa04d6e
Cr-Commit-Position: refs/heads/master@{#347880}