Source/core/paint/SVGContainerPainter.cpp - Issue 1321613002: Refactor ObjectPainter::paintOutline to take a paintOffset

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/paint/SVGContainerPainter.cpp

Issue 1321613002: Refactor ObjectPainter::paintOutline to take a paintOffset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove ObjectPainter::outlineRectForSVG Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/paint/ReplacedPainter.cpp ('k') | Source/core/paint/SVGImagePainter.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "core/paint/SVGContainerPainter.h"	6 #include "core/paint/SVGContainerPainter.h"

7	7

8 #include "core/layout/svg/LayoutSVGContainer.h"	8 #include "core/layout/svg/LayoutSVGContainer.h"

9 #include "core/layout/svg/LayoutSVGViewportContainer.h"	9 #include "core/layout/svg/LayoutSVGViewportContainer.h"

10 #include "core/layout/svg/SVGLayoutSupport.h"	10 #include "core/layout/svg/SVGLayoutSupport.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 paintContext.paintInfo().updatePaintingRootForChildren(&m_layoutSVGC ontainer);	52 paintContext.paintInfo().updatePaintingRootForChildren(&m_layoutSVGC ontainer);

53 for (LayoutObject* child = m_layoutSVGContainer.firstChild(); child; child = child->nextSibling())	53 for (LayoutObject* child = m_layoutSVGContainer.firstChild(); child; child = child->nextSibling())

54 child->paint(paintContext.paintInfo(), IntPoint());	54 child->paint(paintContext.paintInfo(), IntPoint());

55 }	55 }

56 }	56 }

57	57

58 if (paintInfoBeforeFiltering.phase != PaintPhaseForeground)	58 if (paintInfoBeforeFiltering.phase != PaintPhaseForeground)

59 return;	59 return;

60	60

61 if (m_layoutSVGContainer.style()->outlineWidth() && m_layoutSVGContainer.sty le()->visibility() == VISIBLE) {	61 if (m_layoutSVGContainer.style()->outlineWidth() && m_layoutSVGContainer.sty le()->visibility() == VISIBLE) {

	62 PaintInfo outlinePaintInfo(paintInfoBeforeFiltering);

	63 outlinePaintInfo.phase = PaintPhaseSelfOutline;

62 LayoutRect layoutBoundingBox(boundingBox);	64 LayoutRect layoutBoundingBox(boundingBox);

63 LayoutRect visualOverflowRect = ObjectPainter::outlineBounds(layoutBound ingBox, m_layoutSVGContainer.styleRef());	65 ObjectPainter(m_layoutSVGContainer).paintOutline(outlinePaintInfo, m_lay outSVGContainer.outlineVisualOverflowRect(), layoutBoundingBox.size(), layoutBou ndingBox.location());

64 ObjectPainter(m_layoutSVGContainer).paintOutline(paintInfoBeforeFilterin g, layoutBoundingBox, visualOverflowRect);

65 }	66 }

66	67

67 if (paintInfoBeforeFiltering.isPrinting())	68 if (paintInfoBeforeFiltering.isPrinting())

68 ObjectPainter(m_layoutSVGContainer).addPDFURLRectIfNeeded(paintInfoBefor eFiltering, LayoutPoint());	69 ObjectPainter(m_layoutSVGContainer).addPDFURLRectIfNeeded(paintInfoBefor eFiltering, LayoutPoint());

69 }	70 }

70	71

71 } // namespace blink	72 } // namespace blink

OLD	NEW