Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 1321583003: Capture log messages from the helper script. (Closed)

Created:
5 years, 3 months ago by Jamie
Modified:
5 years, 3 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Capture log messages from the helper script. Logging these messages explicitly using LOG means that they get sent to the web-app to help with debugging. Note that this means we lose the timeout. LMK if you think that's more important than the log output. BUG=524538 Committed: https://crrev.com/d0a19d4f0dd2dc5b146b3ba9f261219618a00c41 Cr-Commit-Position: refs/heads/master@{#346782}

Patch Set 1 #

Patch Set 2 : Remove timeout and exit code parameters. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -54 lines) Patch
M remoting/host/setup/daemon_controller_delegate_linux.cc View 1 7 chunks +12 lines, -54 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jamie
ptal
5 years, 3 months ago (2015-08-27 00:54:52 UTC) #2
Lambros
lgtm - please verify that we can still elevate to root.
5 years, 3 months ago (2015-09-01 23:00:53 UTC) #3
Jamie
On 2015/09/01 23:00:53, Lambros wrote: > lgtm - please verify that we can still elevate ...
5 years, 3 months ago (2015-09-01 23:03:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321583003/20001
5 years, 3 months ago (2015-09-01 23:04:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 23:28:20 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 23:29:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0a19d4f0dd2dc5b146b3ba9f261219618a00c41
Cr-Commit-Position: refs/heads/master@{#346782}

Powered by Google App Engine
This is Rietveld 408576698