Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1321573005: [CSS Grid Layout] Flex factor sum must be 1 at least. (Closed)

Created:
5 years, 3 months ago by jfernandez
Modified:
5 years, 3 months ago
CC:
blink-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Flex factor sum must be 1 at least. When trying to find the size of a flexible grid item the algorithm must perform several steps, which are described in the following section of the spec: https://drafts.csswg.org/css-grid/#algo-find-fr-size When the flex factor sum is less than 1, we should use 1 instead so we can apply each factor to the total available size to fill. BUG=520477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201486

Patch Set 1 #

Patch Set 2 : Added layout test. #

Patch Set 3 : Just return if accumulatedFractions is 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -3 lines) Patch
A LayoutTests/fast/css-grid-layout/flex-factor-sum-less-than-1.html View 1 1 chunk +81 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css-grid-layout/flex-factor-sum-less-than-1-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutGrid.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jfernandez
5 years, 3 months ago (2015-08-31 14:19:20 UTC) #2
svillar
lgtm
5 years, 3 months ago (2015-08-31 14:53:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321573005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321573005/40001
5 years, 3 months ago (2015-08-31 15:38:55 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 16:52:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201486

Powered by Google App Engine
This is Rietveld 408576698