Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1321543010: Make IsGestureTyping enabled on by default. (Closed)

Created:
5 years, 3 months ago by SteveT
Modified:
5 years, 3 months ago
Reviewers:
bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make IsGestureTyping enabled on by default. BUG=527500 Committed: https://crrev.com/d58fe78655d2299474d8e51074e74cf527583f15 Cr-Commit-Position: refs/heads/master@{#347858}

Patch Set 1 #

Total comments: 2

Patch Set 2 : simplify check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/keyboard/keyboard_util.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
SteveT
PTAL.
5 years, 3 months ago (2015-09-03 21:50:13 UTC) #2
bshe
https://codereview.chromium.org/1321543010/diff/1/ui/keyboard/keyboard_util.cc File ui/keyboard/keyboard_util.cc (left): https://codereview.chromium.org/1321543010/diff/1/ui/keyboard/keyboard_util.cc#oldcode190 ui/keyboard/keyboard_util.cc:190: return keyboard_switch == switches::kGestureTypingEnabled; perhaps just do: keyboard_switch != ...
5 years, 3 months ago (2015-09-04 14:07:25 UTC) #3
SteveT
Thanks - back to you, Biao. https://codereview.chromium.org/1321543010/diff/1/ui/keyboard/keyboard_util.cc File ui/keyboard/keyboard_util.cc (left): https://codereview.chromium.org/1321543010/diff/1/ui/keyboard/keyboard_util.cc#oldcode190 ui/keyboard/keyboard_util.cc:190: return keyboard_switch == ...
5 years, 3 months ago (2015-09-04 17:50:14 UTC) #5
bshe
lgtm
5 years, 3 months ago (2015-09-04 18:46:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321543010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321543010/40001
5 years, 3 months ago (2015-09-09 02:22:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-09 08:58:37 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 08:59:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d58fe78655d2299474d8e51074e74cf527583f15
Cr-Commit-Position: refs/heads/master@{#347858}

Powered by Google App Engine
This is Rietveld 408576698