Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: src/debug/debug.cc

Issue 1321543004: [futex] Allow debugger to break in the middle of a futexWait Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 5dc1742137b5942daf64f3eeca772bf97c59cdf9..f6969b12389eb906d8eae0121469041b505ad0d2 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -41,6 +41,7 @@ Debug::Debug(Isolate* isolate)
in_debug_event_listener_(false),
break_on_exception_(false),
break_on_uncaught_exception_(false),
+ break_in_nondebuggable_(false),
debug_info_list_(NULL),
isolate_(isolate) {
ThreadInit();
@@ -2244,7 +2245,10 @@ void Debug::HandleDebugBreak() {
Object* fun = it.frame()->function();
if (fun && fun->IsJSFunction()) {
// Don't stop in builtin functions.
- if (!JSFunction::cast(fun)->IsSubjectToDebugging()) return;
+ if (!(JSFunction::cast(fun)->IsSubjectToDebugging() ||
+ break_in_nondebuggable_)) {
+ return;
+ }
GlobalObject* global = JSFunction::cast(fun)->context()->global_object();
// Don't stop in debugger functions.
if (IsDebugGlobal(global)) return;
« no previous file with comments | « src/debug/debug.h ('k') | src/futex-emulation.cc » ('j') | test/cctest/test-debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698