src/execution.cc - Issue 1321543004: [futex] Allow debugger to break in the middle of a futexWait

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/execution.cc

Issue 1321543004: [futex] Allow debugger to break in the middle of a futexWait Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: pass parameter through HandleInterrupts Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/execution.cc

diff --git a/src/execution.cc b/src/execution.cc

index 4ab2403e56f0a0cc9d9345e51e0a233a260ff21c..6f9635d481a85cfd4d14d946e213877e9bfae02c 100644

--- a/src/execution.cc

+++ b/src/execution.cc

@@ -646,13 +646,13 @@ void StackGuard::HandleGCInterrupt() {

}

-Object* StackGuard::HandleInterrupts() {

+Object* StackGuard::HandleInterrupts(BreakInNonDebuggableFlag flag) {

if (CheckAndClearInterrupt(GC_REQUEST)) {

isolate_->heap()->HandleGCRequest();

}

if (CheckDebugBreak() || CheckDebugCommand()) {

- isolate_->debug()->HandleDebugBreak();

+ isolate_->debug()->HandleDebugBreak(flag);

}

if (CheckAndClearInterrupt(TERMINATE_EXECUTION)) {