Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: src/debug/debug.cc

Issue 1321543004: [futex] Allow debugger to break in the middle of a futexWait Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: pass parameter through HandleInterrupts Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.h ('k') | src/execution.h » ('j') | src/execution.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 99036d71e7e7c6df559e192591ff1d36598e35ef..028bfe2448d89e3fc6a0102553a3121781800ee7 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -2261,7 +2261,7 @@ MaybeHandle<Object> Debug::Call(Handle<JSFunction> fun, Handle<Object> data) {
}
-void Debug::HandleDebugBreak() {
+void Debug::HandleDebugBreak(BreakInNonDebuggableFlag flag) {
// Ignore debug break during bootstrapping.
if (isolate_->bootstrapper()->IsActive()) return;
// Just continue if breaks are disabled.
@@ -2277,7 +2277,9 @@ void Debug::HandleDebugBreak() {
Object* fun = it.frame()->function();
if (fun && fun->IsJSFunction()) {
// Don't stop in builtin functions.
- if (!JSFunction::cast(fun)->IsSubjectToDebugging()) return;
+ if (!(JSFunction::cast(fun)->IsSubjectToDebugging() ||
+ flag == BreakInNonDebuggable))
+ return;
GlobalObject* global = JSFunction::cast(fun)->context()->global_object();
// Don't stop in debugger functions.
if (IsDebugGlobal(global)) return;
« no previous file with comments | « src/debug/debug.h ('k') | src/execution.h » ('j') | src/execution.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698