chrome/browser/android/shortcut_helper.h - Issue 1321463002: Cleanup comments and variable name in ShortcutHelper and AddToHomescreenDialogHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 1321463002: Cleanup comments and variable name in ShortcutHelper and AddToHomescreenDialogHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_helper.h

diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h

index 93e1c9d589a86307befc9bbc041867eb15ffadae..b85d52a77aca53d867554e67f6d996dc41c8e7b6 100644

--- a/chrome/browser/android/shortcut_helper.h

+++ b/chrome/browser/android/shortcut_helper.h

@@ -11,8 +11,8 @@

#include "third_party/skia/include/core/SkBitmap.h"

// ShortcutHelper is the C++ counterpart of org.chromium.chrome.browser's

-// ShortcutHelper in Java. The object is owned by the Java object. It is created

-// from there via a JNI (Initialize) call and MUST BE DESTROYED via Destroy().

+// ShortcutHelper in Java. There are no instances of this class so there is

gone 2015/08/26 18:43:43 nit: Don't bother talking about ownership if it do

Lalit Maganti 2015/08/26 19:40:26 Removed.

+// no ownership to consider.

class ShortcutHelper {

public:

// Registers JNI hooks.

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java ('k') | no next file » | no next file with comments »