Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321453012: Added allocator matcros to blink classes and structures in core/svg. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, Eric Willigers, krit, rjwright, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, fs, shans, f(malita), darktears, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added allocator matcros to blink classes and structures in core/svg. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201464

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M Source/core/svg/ColorDistance.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/GradientAttributes.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedRect.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSeg.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGRect.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGRect.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGTransformDistance.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/animation/SMILTime.h View 5 chunks +5 lines, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/properties/SVGListPropertyHelper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/svg/properties/SVGListPropertyTearOffHelper.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-08-28 09:38:47 UTC) #2
haraken
LGTM https://codereview.chromium.org/1321453012/diff/1/Source/core/svg/SVGRect.h File Source/core/svg/SVGRect.h (right): https://codereview.chromium.org/1321453012/diff/1/Source/core/svg/SVGRect.h#newcode35 Source/core/svg/SVGRect.h:35: struct InvalidSVGRectTag { I think we should use ...
5 years, 3 months ago (2015-08-28 09:41:35 UTC) #3
tasak
Thank you for review. https://codereview.chromium.org/1321453012/diff/1/Source/core/svg/SVGRect.h File Source/core/svg/SVGRect.h (right): https://codereview.chromium.org/1321453012/diff/1/Source/core/svg/SVGRect.h#newcode35 Source/core/svg/SVGRect.h:35: struct InvalidSVGRectTag { On 2015/08/28 ...
5 years, 3 months ago (2015-08-28 10:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453012/20001
5 years, 3 months ago (2015-08-31 03:36:52 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 04:55:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201464

Powered by Google App Engine
This is Rietveld 408576698