LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js - Issue 1321453007: Some random Web Notification cleanups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

Issue 1321453007: Some random Web Notification cleanups (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

diff --git a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

index 850f15fb229b358fc4871e9ee7ed1699f82c2c71..cf8e3bcdc4f1d92004f048ca86b70f103a414c86 100644

--- a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

+++ b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

@@ -26,7 +26,5 @@ test(function() {

test(function() {

assert_will_be_idl_attribute(self, 'onnotificationclick',

'The notificationclick event exists.');

- assert_will_be_idl_attribute(self, 'onnotificationerror',

- 'The notificationerror event exists.');

-}, 'The notificationclick and notificationerror events exist on the global scope.');

+}, 'The notificationclick event exist on the global scope.');

whywhat 2015/08/27 19:16:47 nit: exists

Peter Beverloo 2015/08/27 19:20:00 Done.

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »