Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1321453007: Some random Web Notification cleanups (Closed)

Created:
5 years, 3 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
Reviewers:
whywhat, adamk
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, peter+watch_chromium.org, serviceworker-reviews, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Some random Web Notification cleanups This CL cleans up some discrepancies in the Web Notification module and removes unused includes. Furthermore, it: - Merges the ServiceWorkerNotifications and Notifications runtime enabled features. The SWN flag is not being toggled anywhere. - Removes the notificationerror event from the Service Worker global scope. We have never supported this event. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201394

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/notifications/Notification.h View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/notifications/NotificationData.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/modules/notifications/NotificationEvent.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/notifications/NotificationEvent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/NotificationOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/NotificationPermissionCallback.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationPermissionClient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
whywhat
lgtm https://codereview.chromium.org/1321453007/diff/1/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js File LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js (right): https://codereview.chromium.org/1321453007/diff/1/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js#newcode30 LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js:30: }, 'The notificationclick event exist on the global ...
5 years, 3 months ago (2015-08-27 19:16:47 UTC) #2
Peter Beverloo
Thanks Anton! +adamk from the OWNERS round robin for platform/ and web/ (2 lines) :-). ...
5 years, 3 months ago (2015-08-27 19:20:00 UTC) #4
adamk
lgtm for Source/{web,platform} (didn't look at anything else)
5 years, 3 months ago (2015-08-28 00:20:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453007/20001
5 years, 3 months ago (2015-08-28 11:29:42 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 11:34:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201394

Powered by Google App Engine
This is Rietveld 408576698