Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1321453004: Add maximum screen size into constraint for webkitGetuserMedia() (Closed)

Created:
5 years, 3 months ago by GeorgeZ
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BUG=509002 Added maxWidth:screen.width and maxHeight:screen.height constrains for video in webkitGetUserMedia().Therefore, the stream may have higher resolution than 640*480 which is default in webkitGetUserMedia(). Committed: https://crrev.com/709188caa73363b653f67c990c5705c26d4fe9bf Cr-Commit-Position: refs/heads/master@{#351118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/common/extensions/docs/examples/api/desktopCapture/app.js View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
GeorgeZ
Please review it for me.
5 years, 3 months ago (2015-08-26 23:59:03 UTC) #2
Niklas Enbom
lgtm, please: - Change the issue title to describe exactly what the code changes are ...
5 years, 3 months ago (2015-08-27 16:36:04 UTC) #3
GeorgeZ
On 2015/08/27 16:36:04, Niklas Enbom wrote: > lgtm, please: > - Change the issue title ...
5 years, 3 months ago (2015-08-27 17:03:25 UTC) #5
GeorgeZ
mkearney, Please have a review for me. Thanks, George
5 years, 3 months ago (2015-08-27 17:04:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453004/1
5 years, 2 months ago (2015-09-28 17:37:53 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-28 17:37:55 UTC) #9
gyzhou
On 2015/09/28 17:37:55, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 2 months ago (2015-09-28 17:48:48 UTC) #10
mkearney1
lgtm
5 years, 2 months ago (2015-09-28 18:07:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453004/1
5 years, 2 months ago (2015-09-28 18:10:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453004/1
5 years, 2 months ago (2015-09-28 18:29:11 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:38:43 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:39:44 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/709188caa73363b653f67c990c5705c26d4fe9bf
Cr-Commit-Position: refs/heads/master@{#351118}

Powered by Google App Engine
This is Rietveld 408576698