|
|
Chromium Code Reviews|
Created:
5 years, 3 months ago by GeorgeZ Modified:
5 years, 2 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBUG=509002
Added maxWidth:screen.width and maxHeight:screen.height constrains for video in webkitGetUserMedia().Therefore, the stream may have higher resolution than 640*480 which is default in webkitGetUserMedia().
Committed: https://crrev.com/709188caa73363b653f67c990c5705c26d4fe9bf
Cr-Commit-Position: refs/heads/master@{#351118}
Patch Set 1 #
Messages
Total messages: 18 (6 generated)
gyzhou@chromium.org changed reviewers: + niklase@chromium.org
Please review it for me.
lgtm, please: - Change the issue title to describe exactly what the code changes are doing, something like "Add screen size parameters as resolution constraint" - Run try bots using git cl try - add mkearney as OWNER reviewer, he has reviewed this file in the past On 2015/08/26 23:59:03, GeorgeZ wrote: > Please review it for me.
gyzhou@chromium.org changed reviewers: + mkearney@chromium.org
On 2015/08/27 16:36:04, Niklas Enbom wrote: > lgtm, please: > - Change the issue title to describe exactly what the code changes are doing, > something like "Add screen size parameters as resolution constraint" > - Run try bots using git cl try > - add mkearney as OWNER reviewer, he has reviewed this file in the past > > On 2015/08/26 23:59:03, GeorgeZ wrote: > > Please review it for me. I followed the instruction and will publish+mail comments one more time to include mkearney as OWNER for review
mkearney, Please have a review for me. Thanks, George
The CQ bit was checked by gyzhou@google.com
Message was sent while issue was closed.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453004/1
Message was sent while issue was closed.
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/09/28 17:37:55, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. mkearney, I need your approve to submit this CL. Thanks, George
The CQ bit was checked by mkearney@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453004/1
The CQ bit was unchecked by gyzhou@google.com
The CQ bit was checked by gyzhou@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321453004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/709188caa73363b653f67c990c5705c26d4fe9bf Cr-Commit-Position: refs/heads/master@{#351118} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
