Allow ConvertJavaStringTo* to be called with (JNIEnv, JavaRef).

Allow ConvertJavaStringTo* to be called with (JNIEnv, JavaRef).

Lots of places in the code currently call the two-arg version of
ConvertJavaStringTo* with a JNI method parameter, which is now relying
on the implicit conversion from JavaParamRef<jstring> to jstring. To
avoid this, define a two-arg version that takes a JavaRef as the second
parameter. If we have the environment it's more efficient to keep it
around rather than change all the callers to the one-arg version, since
the one-arg version has to call AttachCurrentThread.

BUG=506850
R=rmcilroy@chromium.org

Committed: https://crrev.com/8a83d34084503b218968d187aa091ec405423477
Cr-Commit-Position: refs/heads/master@{#348874}

[rmcilroy, 2015-09-14 15:31:03]

Sorry for the delay - totally missed this somehow. LGTM.

[Torne, 2015-09-14 16:31:45]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2015-09-14 16:33:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321423005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321423005/1

[commit-bot: I haz the power, 2015-09-14 16:56:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 16:56:31]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Torne, 2015-09-15 11:50:18]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2015-09-15 11:50:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321423005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321423005/1

[commit-bot: I haz the power, 2015-09-15 12:22:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-15 12:23:33]

Patchset 1 (id:??) landed as
https://crrev.com/8a83d34084503b218968d187aa091ec405423477
Cr-Commit-Position: refs/heads/master@{#348874}

[commit-bot: I haz the power, 2015-09-23 12:44:21]

Patchset 1 (id:??) landed as
https://crrev.com/8a83d34084503b218968d187aa091ec405423477
Cr-Commit-Position: refs/heads/master@{#348874}