src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1321343004: Desugar %DefaultConstructorCallSuper partially in parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1321343004: Desugar %DefaultConstructorCallSuper partially in parser. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 23df7a764dffc7eca6810539c3bd27702e31a2f9..8af4a7ae5fc69a718cfdbf17e3dc3e384574ecba 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -4021,13 +4021,9 @@ void FullCodeGenerator::EmitDefaultConstructorCallSuper(CallRuntime* expr) {

ZoneList<Expression*>* args = expr->arguments();

DCHECK(args->length() == 2);

- // new.target

+ // Evaluate new.target and super constructor.

VisitForStackValue(args->at(0));

- // .this_function

VisitForStackValue(args->at(1));

- __ CallRuntime(Runtime::kGetPrototype, 1);

- __ push(result_register());

// Load original constructor into ecx.

__ mov(ecx, Operand(esp, 1 * kPointerSize));