Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1321343002: Revert of Stop prepending "r" to commit hashes in merge_to_branch.py (Closed)

Created:
5 years, 3 months ago by Michael Hablich
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Stop prepending "r" to commit hashes in merge_to_branch.py (patchset #1 id:1 of https://codereview.chromium.org/1298973007/ ) Reason for revert: Result when using the script: tools/release/merge_to_branch.py File "tools/release/merge_to_branch.py", line 108 self["revision_list"] = ", ".join(self["full_revision_list"])) ^ SyntaxError: invalid syntax Original issue's description: > Stop prepending "r" to commit hashes in merge_to_branch.py > > R=machenbach@chromium.org > > Committed: https://crrev.com/e5dbfd06c3dab5934e846c40af2a8b7fb5cdf0d6 > Cr-Commit-Position: refs/heads/master@{#30483} TBR=machenbach@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/76fb022fd257ebb9d1d31c9ec4d08332b9a86d48 Cr-Commit-Position: refs/heads/master@{#30505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/release/merge_to_branch.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Hablich
Created Revert of Stop prepending "r" to commit hashes in merge_to_branch.py
5 years, 3 months ago (2015-09-01 11:10:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321343002/1
5 years, 3 months ago (2015-09-01 11:10:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 11:11:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76fb022fd257ebb9d1d31c9ec4d08332b9a86d48 Cr-Commit-Position: refs/heads/master@{#30505}
5 years, 3 months ago (2015-09-01 11:11:22 UTC) #4
Michael Achenbach
On 2015/09/01 11:11:22, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 3 months ago (2015-09-01 11:18:15 UTC) #5
Michael Hablich
5 years, 3 months ago (2015-09-01 11:24:48 UTC) #6
Message was sent while issue was closed.
On 2015/09/01 11:18:15, Michael Achenbach wrote:
> On 2015/09/01 11:11:22, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/76fb022fd257ebb9d1d31c9ec4d08332b9a86d48
> > Cr-Commit-Position: refs/heads/master@{#30505}
> 
> lgtm - fair enough - we should have presubmit checking the syntax of all our
> python scripts... so that there's no need for counting parentheses...

Yeah uploading fix now, didn't want to leave it broken until fix lands.

Powered by Google App Engine
This is Rietveld 408576698