Reorder permission message rules, so that related rules appear together

Reorder permission message rules, so that related rules appear together.

This CL just changes the order of existing rules, it does not change the rules themselves. It does add a couple of TODOs for that, though.

BUG=398257
Committed: https://crrev.com/34708a41c7472f0ec3b2cba985c2dcaeec184fa0
Cr-Commit-Position: refs/heads/master@{#346677}

[Marc Treib, 2015-09-01 13:16:07]

treib@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Marc Treib, 2015-09-01 13:16:07]

Here's that rule reordering. This should make things easier in the future.
Actually adding the missing combinations (e.g. the kSessions things that were
mentioned) will follow in another CL.

https://codereview.chromium.org/1321333003/diff/20001/chrome/common/extension...
File
chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
(left):

https://codereview.chromium.org/1321333003/diff/20001/chrome/common/extension...
chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc:111:
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_LIST),
Here, the order of the two messages changed. We don't really care either way (if
anything, the new order is probably better). In an ideal world, the test would
reflect that and ignore the order, but building an order-independent comparison
here seems like more trouble than it's worth.

[Devlin, 2015-09-01 15:55:24]

LGTM; I'm trusting you that this is only a reordering, because that diff is
really hard to read. ;)

https://codereview.chromium.org/1321333003/diff/20001/chrome/common/extension...
File chrome/common/extensions/permissions/chrome_permission_message_rules.cc
(right):

https://codereview.chromium.org/1321333003/diff/20001/chrome/common/extension...
chrome/common/extensions/permissions/chrome_permission_message_rules.cc:456: //
TODO(treib): Should we have _AND_SESSIONS versions of these 2 as well?
I looked a bit more into it, and I think I understand why this is the case.  The
sessions api includes the ability to query for tabs that were from a session on
a previous device, but those tabs will only be generated with the url if the
extension has the tabs permission.  Having permissions like processes and
navigation doesn't help with that.  So I think this is actually okay.  (That
said, a 1-2 line comment explaining that might be worthwhile so we don't scratch
our heads about this in a month. :))

[Marc Treib, 2015-09-01 15:59:50]

Thanks!
Alternatively, you could also choose to trust our tests, but I'm not sure if
that's more or less reliable than trusting me :D

https://codereview.chromium.org/1321333003/diff/20001/chrome/common/extension...
File chrome/common/extensions/permissions/chrome_permission_message_rules.cc
(right):

https://codereview.chromium.org/1321333003/diff/20001/chrome/common/extension...
chrome/common/extensions/permissions/chrome_permission_message_rules.cc:456: //
TODO(treib): Should we have _AND_SESSIONS versions of these 2 as well?
On 2015/09/01 15:55:24, Devlin wrote:
> I looked a bit more into it, and I think I understand why this is the case. 
The
> sessions api includes the ability to query for tabs that were from a session
on
> a previous device, but those tabs will only be generated with the url if the
> extension has the tabs permission.  Having permissions like processes and
> navigation doesn't help with that.  So I think this is actually okay.  (That
> said, a 1-2 line comment explaining that might be worthwhile so we don't
scratch
> our heads about this in a month. :))

Ah, good to know! Thanks for investigating!
I already sent you a followup CL that adds these AND_SESSIONS rules; I'll update
it to remove them again and instead add that comment.

[Marc Treib, 2015-09-01 16:00:12]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2015-09-01 16:00:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321333003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321333003/20001

[commit-bot: I haz the power, 2015-09-01 17:09:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-01 17:09:59]

Patchset 2 (id:??) landed as
https://crrev.com/34708a41c7472f0ec3b2cba985c2dcaeec184fa0
Cr-Commit-Position: refs/heads/master@{#346677}