Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321273002: LogDog: Add butler protocol reader/write library. (Closed)

Created:
5 years, 3 months ago by dnj
Modified:
5 years, 1 month ago
Reviewers:
estaab, iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, todd, andrew.wang, M-A Ruel, tandrii(chromium)
Base URL:
https://github.com/luci/luci-go@logdog-review-frame
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Add butler protocol reader/write library. BUG= Committed: https://github.com/luci/luci-go/commit/8feba08185ee05ecb5e79044a116047de1bb4dbb

Patch Set 1 #

Patch Set 2 : Added docs. #

Patch Set 3 : Updates. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -0 lines) Patch
A client/logdog/butlerproto/doc.go View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A client/logdog/butlerproto/proto.go View 1 2 1 chunk +247 lines, -0 lines 2 comments Download
A client/logdog/butlerproto/proto_test.go View 1 1 chunk +210 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1253353008 Patch 80001

Dependent Patchsets:

Issue 1429993002 Patch 1

Messages

Total messages: 10 (2 generated)
dnj
PTAL
5 years, 3 months ago (2015-08-31 21:24:47 UTC) #1
dnj
PTAL
5 years, 1 month ago (2015-11-03 18:04:34 UTC) #3
dnj
Review order: (butlerproto) https://codereview.chromium.org/1321273002/ (StreamServer) https://codereview.chromium.org/1429993002/ (Bundler) https://codereview.chromium.org/1412063008/ (Output) https://codereview.chromium.org/1211053004/
5 years, 1 month ago (2015-11-03 20:37:40 UTC) #4
estaab
lgtm https://codereview.chromium.org/1321273002/diff/40001/client/logdog/butlerproto/proto.go File client/logdog/butlerproto/proto.go (right): https://codereview.chromium.org/1321273002/diff/40001/client/logdog/butlerproto/proto.go#newcode155 client/logdog/butlerproto/proto.go:155: if int64(len(p)) > r.limit { Isn't this delaying ...
5 years, 1 month ago (2015-11-04 12:33:24 UTC) #5
dnj
https://codereview.chromium.org/1321273002/diff/40001/client/logdog/butlerproto/proto.go File client/logdog/butlerproto/proto.go (right): https://codereview.chromium.org/1321273002/diff/40001/client/logdog/butlerproto/proto.go#newcode155 client/logdog/butlerproto/proto.go:155: if int64(len(p)) > r.limit { On 2015/11/04 12:33:24, estaab ...
5 years, 1 month ago (2015-11-04 18:19:29 UTC) #6
estaab
lgtm
5 years, 1 month ago (2015-11-04 18:24:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321273002/40001
5 years, 1 month ago (2015-11-04 18:36:01 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 18:38:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/8feba08185ee05ecb5e79044a116047de1bb4dbb

Powered by Google App Engine
This is Rietveld 408576698