Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1321263002: Postpone interrupts while dipatching debugger events to listeners (Closed)

Created:
5 years, 3 months ago by yurys
Modified:
5 years, 3 months ago
Reviewers:
kozy, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Postpone interrupts while dipatching debugger events to listeners The interrupts are already postponed in message handlers [1]. This CL aligns debug event listener (the mechanism that is actually used in Chrome DevTools) implementation with that. Handling interrupts on events like v8::AfterCompile leads to crashes like the one in the lined bug. This happens because in the interrupt handler we may change debugger state. [1] https://codereview.chromium.org/309533009/diff/40001/src/debug.cc BUG=chromium:520702 LOG=Y Committed: https://crrev.com/70dc24c22ff61b4b4d5a9f43597bdbb067b35304 Cr-Commit-Position: refs/heads/master@{#30488}

Patch Set 1 #

Patch Set 2 : Updated comment #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/debug/debug.cc View 1 2 5 chunks +6 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
yurys
5 years, 3 months ago (2015-08-31 20:55:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321263002/1
5 years, 3 months ago (2015-08-31 20:55:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321263002/20001
5 years, 3 months ago (2015-08-31 20:58:08 UTC) #6
kozy
lgtm
5 years, 3 months ago (2015-08-31 20:58:33 UTC) #7
yurys
Yang, please take a look. In next CL I'm going to extract common code from ...
5 years, 3 months ago (2015-08-31 21:02:10 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321263002/40001
5 years, 3 months ago (2015-08-31 21:21:43 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 21:45:07 UTC) #12
Yang
On 2015/08/31 21:45:07, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 3 months ago (2015-08-31 22:17:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321263002/40001
5 years, 3 months ago (2015-08-31 22:31:22 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-31 22:32:52 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 22:33:08 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/70dc24c22ff61b4b4d5a9f43597bdbb067b35304
Cr-Commit-Position: refs/heads/master@{#30488}

Powered by Google App Engine
This is Rietveld 408576698