Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: ipc/handle_attachment_win.cc

Issue 1321253011: Remove dependency on //crypto in //ipc, except on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback_clean
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/brokerable_attachment.cc ('k') | ipc/ipc.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/handle_attachment_win.h" 5 #include "ipc/handle_attachment_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 8
9 #include "crypto/random.h"
10
9 namespace IPC { 11 namespace IPC {
10 namespace internal { 12 namespace internal {
11 13
14 namespace {
15
16 // In order to prevent mutually untrusted processes from stealing resources from
17 // one another, the nonce must be secret. This generates a 128-bit,
18 // cryptographicaly-strong random number.
19 BrokerableAttachment::AttachmentId GenerateAttachementId() {
20 BrokerableAttachment::AttachmentId result;
21 crypto::RandBytes(result.nonce, BrokerableAttachment::kNonceSize);
22 return result;
23 }
24
25 } // namespace
26
12 HandleAttachmentWin::HandleAttachmentWin(const HANDLE& handle, 27 HandleAttachmentWin::HandleAttachmentWin(const HANDLE& handle,
13 HandleWin::Permissions permissions) 28 HandleWin::Permissions permissions)
14 : handle_(handle), permissions_(permissions) {} 29 : BrokerableAttachment(GenerateAttachementId(), true),
30 handle_(handle),
31 permissions_(permissions) {}
15 32
16 HandleAttachmentWin::HandleAttachmentWin(const WireFormat& wire_format) 33 HandleAttachmentWin::HandleAttachmentWin(const WireFormat& wire_format)
17 : BrokerableAttachment(wire_format.attachment_id, false), 34 : BrokerableAttachment(wire_format.attachment_id, false),
18 handle_(LongToHandle(wire_format.handle)), 35 handle_(LongToHandle(wire_format.handle)),
19 permissions_(wire_format.permissions) {} 36 permissions_(wire_format.permissions) {}
20 37
21 HandleAttachmentWin::HandleAttachmentWin( 38 HandleAttachmentWin::HandleAttachmentWin(
22 const BrokerableAttachment::AttachmentId& id) 39 const BrokerableAttachment::AttachmentId& id)
23 : BrokerableAttachment(id, true), 40 : BrokerableAttachment(id, true),
24 handle_(INVALID_HANDLE_VALUE), 41 handle_(INVALID_HANDLE_VALUE),
(...skipping 25 matching lines...) Expand all
50 WireFormat format; 67 WireFormat format;
51 format.handle = HandleToLong(handle_); 68 format.handle = HandleToLong(handle_);
52 format.attachment_id = GetIdentifier(); 69 format.attachment_id = GetIdentifier();
53 format.destination_process = destination; 70 format.destination_process = destination;
54 format.permissions = permissions_; 71 format.permissions = permissions_;
55 return format; 72 return format;
56 } 73 }
57 74
58 } // namespace internal 75 } // namespace internal
59 } // namespace IPC 76 } // namespace IPC
OLDNEW
« no previous file with comments | « ipc/brokerable_attachment.cc ('k') | ipc/ipc.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698