Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321253010: Add a "native_support" service. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
vardhan
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a "native_support" service. This is a service intended to be used by other native Mojo apps, and is not for general use. By design, it's specific to the underlying native platform (e.g., POSIX). Currently, native_support simply allows you to spawn native binaries (redirecting stdin/stdout/stderr). This includes a demo app that shows how this capability may be used in conjunction with a mojo terminal (moterm). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c8e6b8094c0e6329178e3f82a24aaf082e7b149a

Patch Set 1 #

Patch Set 2 : asdf #

Patch Set 3 : wip13.1 #

Patch Set 4 : wip13.3 #

Patch Set 5 : wip13.6 #

Patch Set 6 : wip14 - handle responses #

Patch Set 7 : oops #

Patch Set 8 : ioctls #

Patch Set 9 : asdf #

Patch Set 10 : asdf #

Patch Set 11 : fix android? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1796 lines, -15 lines) Patch
M apps/moterm/moterm_driver.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M examples/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A + examples/native_run_app/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +3 lines, -6 lines 0 comments Download
A examples/native_run_app/native_run_app.cc View 1 2 3 4 5 6 7 8 1 chunk +251 lines, -0 lines 0 comments Download
M mojo/services/mojo_services.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/services/native_support/public/interfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A mojo/services/native_support/public/interfaces/process.mojom View 1 2 3 4 5 6 7 8 1 chunk +65 lines, -0 lines 0 comments Download
M mojo/tools/data/apptests View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M services/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
A services/native_support/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +58 lines, -0 lines 0 comments Download
A services/native_support/main.cc View 1 2 3 4 5 6 7 8 1 chunk +62 lines, -0 lines 0 comments Download
A services/native_support/make_pty_pair.h View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
A services/native_support/make_pty_pair.cc View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
A services/native_support/process_controller_impl.h View 1 2 3 4 5 6 7 8 1 chunk +57 lines, -0 lines 0 comments Download
A services/native_support/process_controller_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +122 lines, -0 lines 0 comments Download
A services/native_support/process_controller_impl_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +196 lines, -0 lines 0 comments Download
A services/native_support/process_impl.h View 1 2 3 4 5 6 7 8 1 chunk +69 lines, -0 lines 0 comments Download
A services/native_support/process_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +239 lines, -0 lines 0 comments Download
A services/native_support/process_impl_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +142 lines, -0 lines 0 comments Download
A services/native_support/process_io_redirection.h View 1 2 3 4 5 6 7 8 1 chunk +74 lines, -0 lines 0 comments Download
A services/native_support/process_io_redirection.cc View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A + services/native_support/process_test_base.h View 2 chunks +25 lines, -5 lines 0 comments Download
A services/native_support/process_test_base.cc View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A services/native_support/redirectors.h View 1 1 chunk +84 lines, -0 lines 0 comments Download
A services/native_support/redirectors.cc View 1 2 3 1 chunk +173 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years, 2 months ago (2015-09-30 19:23:18 UTC) #2
vardhan
lgtm i understood it
5 years, 2 months ago (2015-10-01 21:31:48 UTC) #3
viettrungluu
5 years, 2 months ago (2015-10-01 21:58:58 UTC) #4
Message was sent while issue was closed. 
Committed patchset #11 (id:200001) manually as
c8e6b8094c0e6329178e3f82a24aaf082e7b149a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698