src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp - Issue 1321253003: emitChild() takes an outputColor instead of generating one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp

Issue 1321253003: emitChild() takes an outputColor instead of generating one (Closed) Base URL: https://skia.googlesource.com/skia@cs3_composeshader2

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp

diff --git a/src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp b/src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp

index 3414df2b135bb548d93223858bf18db197873af9..c5ee9b8571c285c9b44572fe252c343dbf8fcd8b 100644

--- a/src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp

+++ b/src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp

@@ -16,9 +16,7 @@ public:

void emitCode(EmitArgs& args) override {

GrGLFragmentBuilder* fsBuilder = args.fBuilder->getFragmentShaderBuilder();

fsBuilder->codeAppendf("vec4 alpha4 = %s.aaaa;", args.fInputColor);

- SkString output;

- this->emitChild(0, "alpha4", &output, args);

- fsBuilder->codeAppendf("%s = %s;", args.fOutputColor, output.c_str());

+ this->emitChild(0, "alpha4", args.fOutputColor, args);

}

private:

« no previous file with comments | « src/core/SkComposeShader.cpp ('k') | src/gpu/gl/GrGLFragmentProcessor.h » ('j') | no next file with comments »