Stop using SkScalerContext::getAdvance() in SkGlyphCache.

Stop using SkScalerContext::getAdvance() in SkGlyphCache.

We think it'll simplify things to just always get the full metrics.
On most platforms, it's no different, and we think the platforms that
do differ (FreeType) will be nearly just as cheap.

Removing this distinction helps us make SkGlyphCaches concurrent by
removing a state (we-have-only-advances) from its logical state machine.

We see no significant changes running SKPs before and after this CL.
That makes sense, of course, because the SKPs bake some of this into drawPosText.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/518a2923f11b819fa44ed5cff54155326959540f

[mtklein_C, 2015-09-01 18:00:10]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 18:00:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321243004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321243004/1

[mtklein_C, 2015-09-01 18:01:06]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com, herb@google.com, reed@google.com

[commit-bot: I haz the power, 2015-09-01 18:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 18:05:15]

Dry run: This issue passed the CQ dry run.

[herb_g, 2015-09-01 18:24:03]

There could be more collapsing of code, but that would only make the merge with
my code worse. So, I think this looks good.

https://codereview.chromium.org/1321243004/diff/1/src/core/SkGlyphCache.h
File src/core/SkGlyphCache.h (left):

https://codereview.chromium.org/1321243004/diff/1/src/core/SkGlyphCache.h#old...
src/core/SkGlyphCache.h:221: // Return a new SkGlyph for the glyph ID and
subpixel position id. Limit the amount
Fix comment.

[mtklein_C, 2015-09-01 18:26:02]

agreed

https://codereview.chromium.org/1321243004/diff/1/src/core/SkGlyphCache.h
File src/core/SkGlyphCache.h (left):

https://codereview.chromium.org/1321243004/diff/1/src/core/SkGlyphCache.h#old...
src/core/SkGlyphCache.h:221: // Return a new SkGlyph for the glyph ID and
subpixel position id. Limit the amount
On 2015/09/01 18:24:03, herb_g wrote:
> Fix comment.

Done.

[herb_g, 2015-09-01 18:27:29]

lgtm

[bungeman-skia, 2015-09-01 18:39:39]

lgtm

[reed1, 2015-09-01 19:20:27]

band-wagon-lgtm

[mtklein, 2015-09-01 19:26:07]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-09-01 19:26:08]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-09-01 19:26:08]

lgtm

We're going on an adventure!

[commit-bot: I haz the power, 2015-09-01 19:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321243004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321243004/20001

[commit-bot: I haz the power, 2015-09-01 19:32:27]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/518a2923f11b819fa44ed5cff54155326959540f

[mtklein, 2015-10-06 14:00:21]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1383403003/ by mtklein@google.com.

The reason for reverting is: Suspect this is the cause of regressions in
crbug.com/527445.  It's triggering on Windows and Linux, where getting advances
does less than getting full metrics.  It's not triggering on Mac, where this CL
was a no-op..