Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 132123004: Target touches to the correct display. (Closed)

Created:
6 years, 11 months ago by tdresser
Modified:
6 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Target touches to the correct display. ui::TouchEvents now know the id of their source device. The target of a touch can't be effected by a touch on another display. Relanding https://codereview.chromium.org/103173004/, after it was reverted https://codereview.chromium.org/103173004. When ensuring that the GR wasn't reused between tests, I had neglected to delete the old GR. BUG=315651 TEST=GestureRecognizerTest.GestureEventTouchLockIgnoresOtherScreens Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -22 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 4 chunks +39 lines, -9 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_targeter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/event.h View 4 chunks +9 lines, -1 line 0 comments Download
M ui/events/event.cc View 5 chunks +13 lines, -3 lines 0 comments Download
M ui/events/gestures/gesture_point.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/events/gestures/gesture_point.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer.h View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M ui/events/gestures/gesture_sequence.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tdresser
Sadrul, can you take a look? Only change from https://codereview.chromium.org/103173004 is: void GestureRecognizer::Reset() { + ...
6 years, 11 months ago (2014-01-10 14:08:45 UTC) #1
sadrul
We don't use scoped_ptr<> for other similar singleton objects (e.g. aura::Env, ash::Shell). So this looks ...
6 years, 11 months ago (2014-01-10 16:59:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/132123004/1
6 years, 11 months ago (2014-01-10 17:05:04 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 19:52:59 UTC) #4
Message was sent while issue was closed.
Change committed as 244220

Powered by Google App Engine
This is Rietveld 408576698