Use scan codes when sending keyboard events froms physical keyboard.

Use scan codes when sending keyboard events froms physical keyboard.

Previously android app was using key code when sending keyboard events.
That approach doesn't work well with physical keyboard when using
layout other than QWERTY. Fixed the client to use scan codes, so that
the events are always send correctly and layout mapping is applied
only on the client.

BUG=475713
Committed: https://crrev.com/1da4a34ed8a9fb153dd8924559534ead67d667f6
Cr-Commit-Position: refs/heads/master@{#347874}

[Sergey Ulanov, 2015-09-08 23:11:24]

sergeyu@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2015-09-08 23:39:44]

lgtm with comments

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:303: //
deprecated, but they still need to be here for older devices and
Who says they are deprecated? I checked the Android docs, and didn't find any
deprecation notices.

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:300: *
is used, otherwise keyCode is ignored. */
s/keyCode is ignored/scanCode is used/ ?

Maybe add this information to the public sendKeyEvent method rather than this
private method?

https://codereview.chromium.org/1321223003/diff/1/remoting/client/jni/chromot...
File remoting/client/jni/chromoting_jni_instance.cc (right):

https://codereview.chromium.org/1321223003/diff/1/remoting/client/jni/chromot...
remoting/client/jni/chromoting_jni_instance.cc:236: // For software keyboards
|scan_code| is set to 0, in which case the
in which case the ... what?

https://codereview.chromium.org/1321223003/diff/1/remoting/remoting_android.gypi
File remoting/remoting_android.gypi (right):

https://codereview.chromium.org/1321223003/diff/1/remoting/remoting_android.g...
remoting/remoting_android.gypi:31:
'../ui/events/events.gyp:dom_keycode_converter',
Move this above /ui/gfx/

[Sergey Ulanov, 2015-09-09 00:30:07]

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:303: //
deprecated, but they still need to be here for older devices and
On 2015/09/08 23:39:43, Lambros wrote:
> Who says they are deprecated? I checked the Android docs, and didn't find any
> deprecation notices.

https://source.android.com/devices/input/keyboard-devices.html#legacy-unsuppo...
Added the link in the comment.
That page doesn't mention KEYCODE_PLUS as deprecated, but it's not mentioned
anywhere else on that page and I don't see it generated anymore, so it seems to
be deprecated as well.

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/1321223003/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:300: *
is used, otherwise keyCode is ignored. */
On 2015/09/08 23:39:44, Lambros wrote:
> s/keyCode is ignored/scanCode is used/ ?
> 
> Maybe add this information to the public sendKeyEvent method rather than this
> private method?

Done.

https://codereview.chromium.org/1321223003/diff/1/remoting/client/jni/chromot...
File remoting/client/jni/chromoting_jni_instance.cc (right):

https://codereview.chromium.org/1321223003/diff/1/remoting/client/jni/chromot...
remoting/client/jni/chromoting_jni_instance.cc:236: // For software keyboards
|scan_code| is set to 0, in which case the
On 2015/09/08 23:39:44, Lambros wrote:
> in which case the ... what?

Done.

https://codereview.chromium.org/1321223003/diff/1/remoting/remoting_android.gypi
File remoting/remoting_android.gypi (right):

https://codereview.chromium.org/1321223003/diff/1/remoting/remoting_android.g...
remoting/remoting_android.gypi:31:
'../ui/events/events.gyp:dom_keycode_converter',
On 2015/09/08 23:39:44, Lambros wrote:
> Move this above /ui/gfx/

Done.

[Sergey Ulanov, 2015-09-09 00:30:09]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-09 00:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/1321223003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-09-09 00:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321223003/20001

[commit-bot: I haz the power, 2015-09-09 09:09:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-09 09:10:21]

Patchset 2 (id:??) landed as
https://crrev.com/1da4a34ed8a9fb153dd8924559534ead67d667f6
Cr-Commit-Position: refs/heads/master@{#347874}