Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1321183002: Get rid of static function localCaretRectOf() in VisiblePosition.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-31T17:51:24 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index d8c97ee1dff8087dbb5aca12a256c3d156845bd3..2a9dca28a1f2829e6d36d1fc8562678c5708455c 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -709,17 +709,10 @@ UChar32 characterBefore(const VisiblePosition& visiblePosition)
return characterAfter(previousPositionOf(visiblePosition));
}
-// TODO(yosin) We should move |localCaretRect()| to "VisibleUnits.cpp".
-static LayoutRect localCaretRectOf(const VisiblePosition& visiblePosition, LayoutObject*& layoutObject)
-{
- PositionWithAffinity positionWithAffinity(visiblePosition.deepEquivalent(), visiblePosition.affinity());
- return localCaretRectOfPosition(positionWithAffinity, layoutObject);
-}
-
IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
{
LayoutObject* layoutObject;
- LayoutRect localRect = localCaretRectOf(visiblePosition, layoutObject);
+ LayoutRect localRect = localCaretRectOfPosition(visiblePosition.toPositionWithAffinity(), layoutObject);
if (localRect.isEmpty() || !layoutObject)
return IntRect();
@@ -735,7 +728,7 @@ int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition& visib
return 0;
LayoutObject* layoutObject;
- LayoutRect localRect = localCaretRectOf(visiblePosition, layoutObject);
+ LayoutRect localRect = localCaretRectOfPosition(visiblePosition.toPositionWithAffinity(), layoutObject);
if (localRect.isEmpty() || !layoutObject)
return 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698