Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1321173002: Oilpan: fix building with blink_gc_profiling:1 (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix building with blink_gc_profiling:1 R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/heap/HeapPage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 3 months ago (2015-08-31 06:56:22 UTC) #2
haraken
LGTM BTW, given that ssid@ ported all the information in the GC_PROFILER into memory-infra, we're ...
5 years, 3 months ago (2015-08-31 07:07:01 UTC) #3
sof
On 2015/08/31 07:07:01, haraken wrote: > LGTM > > BTW, given that ssid@ ported all ...
5 years, 3 months ago (2015-08-31 07:15:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321173002/1
5 years, 3 months ago (2015-08-31 07:16:37 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 08:03:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201473

Powered by Google App Engine
This is Rietveld 408576698