Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1321143002: Make GetCommandExecuteImplClsid return the CLSID as a string directly. (Closed)

Created:
5 years, 3 months ago by gab
Modified:
5 years, 3 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a1_no_delegate_execute_win10
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GetCommandExecuteImplClsid return the CLSID as a string directly. BUG=Unjustified single out-param. Committed: https://crrev.com/c62bb4ac21755405ec6b8eb9379b2b551478df26 Cr-Commit-Position: refs/heads/master@{#346915}

Patch Set 1 #

Total comments: 6

Patch Set 2 : review:grt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -37 lines) Patch
M chrome/installer/setup/install_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/chrome_frame_distribution.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/installer/util/chromium_binaries_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/chromium_binaries_distribution.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution_dummy.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
gab
Greg: as discussed on https://codereview.chromium.org/1294863006/, PTAL.
5 years, 3 months ago (2015-08-29 14:38:53 UTC) #3
gab
On 2015/08/29 14:38:53, gab wrote: > Greg: as discussed on https://codereview.chromium.org/1294863006/, PTAL. ping, thanks!
5 years, 3 months ago (2015-09-01 16:22:06 UTC) #5
grt (UTC plus 2)
good old google_chrome_distribution_dummy.cc! lgtm w/ below changes. thanks for this cleanup! https://codereview.chromium.org/1321143002/diff/20001/chrome/installer/util/chrome_frame_distribution.cc File chrome/installer/util/chrome_frame_distribution.cc (right): ...
5 years, 3 months ago (2015-09-01 20:02:27 UTC) #6
gab
Thanks, comments addressed. https://codereview.chromium.org/1321143002/diff/20001/chrome/installer/util/chrome_frame_distribution.cc File chrome/installer/util/chrome_frame_distribution.cc (right): https://codereview.chromium.org/1321143002/diff/20001/chrome/installer/util/chrome_frame_distribution.cc#newcode112 chrome/installer/util/chrome_frame_distribution.cc:112: return L""; On 2015/09/01 20:02:27, grt ...
5 years, 3 months ago (2015-09-02 14:23:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321143002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321143002/60001
5 years, 3 months ago (2015-09-02 14:23:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 3 months ago (2015-09-02 14:44:18 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 14:45:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c62bb4ac21755405ec6b8eb9379b2b551478df26
Cr-Commit-Position: refs/heads/master@{#346915}

Powered by Google App Engine
This is Rietveld 408576698