Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Issue 1321133003: Make nextBoundary() to use lastPositionInNode() instead of RangeBoundaryPoint::setToEndOfNode() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make nextBoundary() to use lastPositionInNode() instead of RangeBoundaryPoint::setToEndOfNode() This patch changes |nextBoundary()| to use |lastPositionInNode()| instead of |RangeBoundaryPoint::setToEndNode()| as preparation of making |nextBoundary()| to work on composed tree, since |Position| class is templatzied to support composed tree but |RangeBoundaryPoint| isn't. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201703

Patch Set 1 : 2015-09-03T13:22:08 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-03 05:05:49 UTC) #2
tkent
rs lgtm
5 years, 3 months ago (2015-09-03 05:16:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321133003/1
5 years, 3 months ago (2015-09-03 05:33:36 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 06:30:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201703

Powered by Google App Engine
This is Rietveld 408576698