Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 132113009: MIPS: Fix crashes after profile entry hook calls. (Closed)

Created:
6 years, 10 months ago by dusmil
Modified:
6 years, 10 months ago
Reviewers:
kisg, Paul Lind, palfia, kilvadyb
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix crashes after profile entry hook calls. The call to C++ function has to be done through t9 register for the position independent code. The crashes occur only for shared library build. TEST=cctest/test-api/SetFunctionEntryHook BUG= Committed: https://code.google.com/p/v8/source/detail?r=19121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/mips/code-stubs-mips.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dusmil
6 years, 10 months ago (2014-02-05 19:19:08 UTC) #1
Paul Lind
LGTM, I'll land this one.
6 years, 10 months ago (2014-02-05 22:27:47 UTC) #2
Paul Lind
6 years, 10 months ago (2014-02-05 22:32:38 UTC) #3
Committed as r19121.

Powered by Google App Engine
This is Rietveld 408576698