Source/web/WebScreenOrientationController.cpp - Issue 132113006: Add initial Blink-side support for the Screen Orientation API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/WebScreenOrientationController.cpp

Issue 132113006: Add initial Blink-side support for the Screen Orientation API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "WebScreenOrientationController.h"

	7

	8 #include "modules/screen_orientation/ScreenOrientationController.h"

	9

	10 namespace blink {

	11

	12 void WebScreenOrientationController::orientationChanged(WebScreenOrientation ori entation)

	13 {

	14 m_private->orientationChanged(static_cast<WebCore::ScreenOrientationValue>(o rientation));
	Peter Beverloo 2014/02/12 18:19:37 Can we add some COMPILE_ASSERTS to make sure that Can we add some COMPILE_ASSERTS to make sure that the WebScreenOrientation values stay in sync with ScreenOrientationValue? Inactive 2014/02/12 19:38:37 Good idea, Done. Show quoted text On 2014/02/12 18:19:37, Peter Beverloo wrote: > Can we add some COMPILE_ASSERTS to make sure that the WebScreenOrientation > values stay in sync with ScreenOrientationValue? Good idea, Done.
	15 }

	16

	17 } // namespace blink

OLD	NEW