LayoutTests/screen_orientation/locking-failure.html - Issue 132113006: Add initial Blink-side support for the Screen Orientation API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/screen_orientation/locking-failure.html

Issue 132113006: Add initial Blink-side support for the Screen Orientation API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/screen_orientation/locked-no-orientation-change-event.html ('K') | « LayoutTests/screen_orientation/locked-no-orientation-change-event-expected.txt ('k') | LayoutTests/screen_orientation/locking-failure-expected.txt » ('j') | LayoutTests/screen_orientation/screenorientation-api.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/js-test.js"></script>

	5 <script>

	6 description("Validates that screen.lockOrientation() returns false on bad input" );

	7 window.jsTestIsAsync = true;

	8

	9 function onOrientationChangeEvent(ev) {

	10 testFailed("Unexpected 'orientationchange' event");

	11 }

	12

	13 function completeTest() {

	14 shouldBeEqualToString("screen.orientation", "portrait-primary");

	15 screen.unlockOrientation();

	16 finishJSTest();

	17 }

	18

	19 screen.addEventListener("orientationchange", onOrientationChangeEvent);

	20

	21 shouldBeEqualToString("screen.orientation", "portrait-primary");

	22 shouldBeFalse("screen.lockOrientation('invalid-orientation')");

	23 shouldBeEqualToString("screen.orientation", "portrait-primary");

	24 shouldThrow("screen.lockOrientation()", '"TypeError: Failed to execute \'lockOri entation\' on \'Screen\': 1 argument required, but only 0 present."');
	mlamouri (slow - plz ping) 2014/02/12 20:11:26 Could you add tests that pass some garbage values Could you add tests that pass some garbage values like special values (null, undefined), objects, integers and strings that are different from the 6 known keywords? Inactive 2014/02/12 21:08:04 Done. Show quoted text On 2014/02/12 20:11:26, Mounir Lamouri wrote: > Could you add tests that pass some garbage values like special values (null, > undefined), objects, integers and strings that are different from the 6 known > keywords? Done.
	25

	26 // Finish asynchronously to give events a chance to fire.

	27 setTimeout(completeTest, 100);

	28 </script>

	29 </body>

	30 </html>

OLD	NEW