LayoutTests/screen_orientation/locked-no-orientation-change-event.html - Issue 132113006: Add initial Blink-side support for the Screen Orientation API

Side by Side Diff: LayoutTests/screen_orientation/locked-no-orientation-change-event.html

Issue 132113006: Add initial Blink-side support for the Screen Orientation API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html ('K') | « LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt ('k') | LayoutTests/screen_orientation/locked-no-orientation-change-event-expected.txt » ('j') | LayoutTests/screen_orientation/locking-failure.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/js-test.js"></script>

	5 <script>

	6 description("Validates that no orientationchange event is fired when we are lock ed.");
	mlamouri (slow - plz ping) 2014/02/12 20:11:26 This test seems to essentially test the mock objec This test seems to essentially test the mock object. It is the role of the backend to make sure the orientation does not change. If the ScreenOrientationController gets an orientationChanged call for 'portrait-secondary' while the screen is locked to 'portrait-primary', Blink couldn't do much to fix the situation: the screen orientation would have changed and not firing the event might not even be the right thing to do. Inactive 2014/02/12 21:08:04 So you want to remove this layout test? Show quoted text On 2014/02/12 20:11:26, Mounir Lamouri wrote: > This test seems to essentially test the mock object. It is the role of the > backend to make sure the orientation does not change. If the > ScreenOrientationController gets an orientationChanged call for > 'portrait-secondary' while the screen is locked to 'portrait-primary', Blink > couldn't do much to fix the situation: the screen orientation would have changed > and not firing the event might not even be the right thing to do. So you want to remove this layout test? mlamouri (slow - plz ping) 2014/02/13 16:12:08 I guess we could remove it yes. There is no point Show quoted text On 2014/02/12 21:08:04, Chris Dumez wrote: > On 2014/02/12 20:11:26, Mounir Lamouri wrote: > > This test seems to essentially test the mock object. It is the role of the > > backend to make sure the orientation does not change. If the > > ScreenOrientationController gets an orientationChanged call for > > 'portrait-secondary' while the screen is locked to 'portrait-primary', Blink > > couldn't do much to fix the situation: the screen orientation would have > changed > > and not firing the event might not even be the right thing to do. > > So you want to remove this layout test? I guess we could remove it yes. There is no point in keeping that test and it might give the wrong impression that this behaviour is actually tested. Inactive 2014/02/13 17:03:24 Done. Show quoted text On 2014/02/13 16:12:08, Mounir Lamouri wrote: > On 2014/02/12 21:08:04, Chris Dumez wrote: > > On 2014/02/12 20:11:26, Mounir Lamouri wrote: > > > This test seems to essentially test the mock object. It is the role of the > > > backend to make sure the orientation does not change. If the > > > ScreenOrientationController gets an orientationChanged call for > > > 'portrait-secondary' while the screen is locked to 'portrait-primary', Blink > > > couldn't do much to fix the situation: the screen orientation would have > > changed > > > and not firing the event might not even be the right thing to do. > > > > So you want to remove this layout test? > > I guess we could remove it yes. There is no point in keeping that test and it > might give the wrong impression that this behaviour is actually tested. Done.
	7 window.jsTestIsAsync = true;

	8

	9 var orientationChangeCount = 0;

	10 var currentTestOrientation = 0;

	11 var testOrientations = [

	12 "portrait-secondary",

	13 "landscape-primary",

	14 "landscape-secondary",

	15 "portrait-primary"

	16 ];

	17

	18 function testComplete() {

	19 screen.unlockOrientation();

	20 finishJSTest();

	21 }

	22

	23 function onOrientationChangeEvent(ev) {

	24 ++orientationChangeCount;

	25 testFailed("Unexpected 'orientationchange' event.");

	26 }

	27

	28 function changeOrientation() {

	29 shouldBeEqualToString("screen.orientation", "portrait-primary");

	30 if (currentTestOrientation == testOrientations.length) {

	31 if (orientationChangeCount)

	32 testFailed("Received " + orientationChangeCount + " unexpected 'orie ntationchange' event(s).");

	33 else

	34 testPassed("Received no 'orientationchange' event, as expected.");

	35 testComplete();

	36 return;

	37 }

	38 debug("Faking device screen orientation change to '" + testOrientations[curr entTestOrientation] +"'...");

	39 internals.setScreenOrientation(document, testOrientations[currentTestOrienta tion++]);

	40 setTimeout(changeOrientation, 100);

	41 }

	42

	43 internals.setScreenOrientationClientMock(document);

	44 screen.addEventListener("orientationchange", onOrientationChangeEvent);

	45

	46 shouldBeEqualToString("screen.orientation", "portrait-primary");

	47 debug("locking orientation to 'portrait-primary'.");

	48 shouldBeTrue("screen.lockOrientation('portrait-primary')");

	49 setTimeout(changeOrientation, 100);

	50 </script>

	51 </body>

	52 </html>

OLD	NEW