LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html - Issue 132113006: Add initial Blink-side support for the Screen Orientation API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

Issue 132113006: Add initial Blink-side support for the Screen Orientation API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/screen_orientation/lockOrientation-array-argument-expected.txt ('k') | LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt » ('j') | LayoutTests/screen_orientation/locked-no-orientation-change-event.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/js-test.js"></script>

	5 <script>

	6 description("Validates that lockOrientation() can take an array in argument.");

	7 window.jsTestIsAsync = true;

	8

	9 var orientationChangeCount = 0;

	10 var currentTestOrientation = 0;

	11 var testOrientations = [

	12 "portrait-secondary",

	13 "landscape-primary",

	14 "landscape-secondary",

	15 "portrait-primary"

	16 ];

	17

	18 function testComplete() {

	19 screen.unlockOrientation();

	20 internals.setScreenOrientation(document, "portrait-primary");

	21 finishJSTest();

	22 }

	23

	24 var testEvent;

	25 function onOrientationChangeEvent(ev) {

	26 ++orientationChangeCount;

	27 testEvent = ev;

	28

	29 testPassed("Received an 'orientationchange' event.");

	30 shouldBeEqualToString("testEvent.type", "orientationchange");

	31 shouldBe("orientationChangeCount", "1");

	32 shouldBeEqualToString("screen.orientation", "landscape-primary");

	33 testComplete();

	34 }

	35

	36 function changeOrientation() {

	37 internals.setScreenOrientation(document, testOrientations[currentTestOrienta tion++]);

	38 if (currentTestOrientation < testOrientations.length)

	39 setTimeout(changeOrientation, 100);

	40 }

	41

	42 internals.setScreenOrientationClientMock(document);

	43 screen.addEventListener("orientationchange", onOrientationChangeEvent);

	44

	45 shouldBeEqualToString("screen.orientation", "portrait-primary");

	46 // Bad argument to lockOrientation(), we should not get locked.

	47 shouldBeFalse("screen.lockOrientation(['portrait-primary', 'invalid-orientation' ])");
	mlamouri (slow - plz ping) 2014/02/12 20:11:26 Maybe you could test that false is returned with d Maybe you could test that false is returned with different values that just an invalid string? Inactive 2014/02/12 21:08:04 Done. Show quoted text On 2014/02/12 20:11:26, Mounir Lamouri wrote: > Maybe you could test that false is returned with different values that just an > invalid string? Done.
	48 debug("Faking device screen orientation change to 'landscape-primary'...");

	49 internals.setScreenOrientation(document, "landscape-primary");

	50 </script>

	51 </body>

	52 </html>

OLD	NEW