LayoutTests/screen_orientation/locking-then-unlocking.html - Issue 132113006: Add initial Blink-side support for the Screen Orientation API

Side by Side Diff: LayoutTests/screen_orientation/locking-then-unlocking.html

Issue 132113006: Add initial Blink-side support for the Screen Orientation API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add Kenneth as OWNER Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/screen_orientation/lockOrientation-array-argument.html ('K') | « LayoutTests/screen_orientation/locking-fires-event-expected.txt ('k') | LayoutTests/screen_orientation/locking-then-unlocking-expected.txt » ('j') | Source/core/frame/Screen.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/js-test.js"></script>

	5 <script>

	6 description("Validates that screen orientation can be unlocked");

	7 window.jsTestIsAsync = true;

	8

	9 var orientationChangeEventCount = 0;

	10 var locked = false;

	11

	12 function checkNoOrientationChangeThenContinue() {

	13 shouldBeEqualToString("screen.orientation", "portrait-primary");

	14 shouldBe("orientationChangeEventCount", "0");

	15 debug("Unlocking orientation...");

	16 locked = false;

	17 screen.unlockOrientation();

	18 }

	19

	20 function completeTest() {

	21 screen.removeEventListener("orientationchange", onOrientationChangeEvent);

	22 internals.setScreenOrientation(document, "portrait-primary");

	23 finishJSTest();

	24 }

	25

	26 var testEvent;

	27 function onOrientationChangeEvent(ev) {

	28 ++orientationChangeEventCount;

	29 testEvent = ev;

	30 debug("Received an 'orientationchange' event.");

	31 shouldBeFalse('locked');

	32 shouldBe("orientationChangeEventCount", "1");

	33 shouldBeEqualToString("testEvent.type", "orientationchange");

	34 shouldBeEqualToString("screen.orientation", "landscape-primary");

	35 completeTest();

	36 }

	37

	38 function setScreenOrientationtoLandscapePrimary() {

	39 debug("Faking device screen orientation change to 'landscape-primary'...");

	40 internals.setScreenOrientation(document, "landscape-primary");

	41 setTimeout(checkNoOrientationChangeThenContinue, 200);

	42 }

	43

	44 internals.setScreenOrientationClientMock(document);

	45 screen.addEventListener("orientationchange", onOrientationChangeEvent);

	46

	47 shouldBeEqualToString("screen.orientation", "portrait-primary");
	kenneth.r.christiansen 2014/02/12 13:42:37 according to the spec a platform can say that it o according to the spec a platform can say that it only supports a subset of the orientations and it should fail if the lock includes orientations not supported. ie it might only support ['landscape-primary']. I guess you will handle this from chromium side, but maybe it could be tested with the mock as well? Inactive 2014/02/12 16:03:11 Yes, this has to happen on Chromium side as this m Show quoted text On 2014/02/12 13:42:37, kenneth.r.christiansen wrote: > according to the spec a platform can say that it only supports a subset of the > orientations and it should fail if the lock includes orientations not supported. > ie it might only support ['landscape-primary']. I guess you will handle this > from chromium side, but maybe it could be tested with the mock as well? Yes, this has to happen on Chromium side as this may differ on the various supported platforms. Also, since the locking is asynchronous, we don't currently have a way to tell the JS that the locking failed (i.e. lockOrientation() cannot return false). This will be solved when we switched to Promises though.
	48 debug("locking orientation to 'portrait-primary'.");

	49 locked = true;

	50 shouldBeTrue("screen.lockOrientation('portrait-primary')");

	51 // Doing this asynchronously as lockOrientation() is asynchronous.

	52 setTimeout(setScreenOrientationtoLandscapePrimary, 0);

	53 </script>

	54 </body>

	55 </html>

OLD	NEW